add more function for hvac #36
Conversation
LG AC has 3 kind model roughly, RAC, PAC, SAC SAC is system airconditioner(mostly for commercial), PAC is stand type model, RAC is wall mount type model at least in Korea. So I added these feature below. 1. Add more ac mode(for PAC, RAC, SAC) 2. Add more fan speed(for PAC, RAC, SAC) 3. Add swing mode 4. Add reserve mode 5. Add Extra mode (may be some mode doesn't use at all) 6. Add RAC Submode 7. Add air polution mode 8. Add airclean mode 9. Add wind direction mode(left/right, step) 10. get power usage data 11. add support device function -> In same model type, support different functions each device . so i have to find what function support each device.
|
|
||
| class ACDevice(Device): | ||
| """Higher-level operations on an AC/HVAC device, such as a heat | ||
| pump. | ||
| """ | ||
|
|
||
There was a problem hiding this comment.
Looks like more inadvertent whitespace changes.
| TIMEBS = "@TIMEBS_ONOFF" | ||
| WEEKLYSCHEDULE = "@WEEKLY_SCHEDULE" | ||
|
|
||
| class ACEXTRAMode(enum.Enum): |
There was a problem hiding this comment.
Class names should not use all caps.
| mode_value = self.model.enum_value('AirClean', mode.value) | ||
| self._set_control('AirClean', mode_value) | ||
|
|
||
| def set_etc_mode(self, name, is_on): |
There was a problem hiding this comment.
What's the difference between "etc mode" and "extra mode"?
| """Get outdoor weather""" | ||
|
|
||
| data = self.client.session.get_outdoor_weather(area) | ||
| return data |
There was a problem hiding this comment.
I don't think this is necessary here—the API is associated with the session, not the device.
| time_data = value[i].split('_') | ||
| time.append(int(time_data[1])) | ||
| i = i+1 | ||
| time_sum = sum(time) |
There was a problem hiding this comment.
This stuff looks copied & pasted—can we move it to its own helper function?
| dict_support_airpolution = self.ac.model.option_item('SupportAirPolution') | ||
| support_airpolution = [] | ||
| for option in dict_support_airpolution.values(): | ||
| support_airpolution.append(ACAirPolution(option).name) |
There was a problem hiding this comment.
These "support" functions also share a very common structure. Maybe they can be factored out into a single helper function. Using a list comprehension could also make them more readable (and shorter).
|
|
||
| @property | ||
| def sensorpm10(self): | ||
| return self.data['SensorPM10'] |
There was a problem hiding this comment.
What do these "sensorpmX" properties mean?
If possible, I would love to only expose things in this API that we actually understand. The LG service has a lot of inscrutable garbage in it that is probably not necessary for any client software, and we can keep things simpler by omitting that stuff.
There was a problem hiding this comment.
My guess is those values are PM2.5 and PM10 particulate matter, mostly as a smog.
https://en.wikipedia.org/wiki/Particulates
|
One of many promising PRs that never were accepted. What a pity |
|
Hi, @dacrypt—if you're interested in seeing this merged, maybe you can help out! I left a review with lots of opportunities to improve the code. |
LG AC has 3 kind model roughly, RAC, PAC, SAC
SAC is system airconditioner(mostly for commercial), PAC is stand type model, RAC is wall mount type model at least in Korea.
So I added these feature below.