Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/server: add libcephfs-proxy2 to server image #197

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

spuiuk
Copy link
Collaborator

@spuiuk spuiuk commented Jan 15, 2025

The libcephfs-proxy2 package is required to enable proxy support for the vfs_ceph_new samba vfs module.

Fixes: #196

@spuiuk spuiuk force-pushed the add_proxy branch 2 times, most recently from 4f9369f to 407dabc Compare January 15, 2025 18:06
The libcephfs-proxy2 package is required to enable proxy support for the
vfs_ceph_new samba vfs module.

Signed-off-by: Sachin Prabhu <[email protected]>
@spuiuk
Copy link
Collaborator Author

spuiuk commented Jan 15, 2025

The latest patch installs the libcephfs_proxy2 package only for devbuilds-centos and forcedevbuilds-* where the shaman repo is enabled.

Test runs confirm the following package installed for build-server(devbuilds)

#8 24.15  libcephfs-proxy2         x86_64  2:19.3.0-6879.g3f1f3450.el9       ceph-main              20 k

and package not installed for build-server(nightly)

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code generally LGTM, but I just want to do one manual build with this patch prior to approving!

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@mergify mergify bot merged commit ee4dad1 into samba-in-kubernetes:master Jan 16, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add libcephfs-proxy2 package to the server image
3 participants