Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a script to do the tedious work of fetching digests #185

Merged
merged 1 commit into from
Nov 27, 2024
Merged

docs: add a script to do the tedious work of fetching digests #185

merged 1 commit into from
Nov 27, 2024

Conversation

phlogistonjohn
Copy link
Collaborator

Add a copy-and-paste-able shell script that one can run to generate the downloads section of the release notes. This saves the effort of copy and pasting digests out of the quay.io ui.

obnoxxx
obnoxxx requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request: use env in script shebang line instead of direct path to bash.

idea/suggestion: instead of having a copy-and-paste-able script in the doc, how about having an actual script in the repo?

docs/release-process.md Outdated Show resolved Hide resolved
anoopcs9
anoopcs9 previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

docs/release-process.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed anoopcs9’s stale review November 26, 2024 12:49

Pull request has been modified.

anoopcs9
anoopcs9 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@phlogistonjohn @anoopcs9
docs: add a script to do the tedious work of fetching digests
522fb56 
Add a copy-and-paste-able shell script that one can run to generate
the downloads section of the release notes. This saves the effort
of copy and pasting digests out of the quay.io ui.

Signed-off-by: John Mulligan <[email protected]>
@mergify Mergify
Copy link

mergify bot commented Nov 27, 2024

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the jjm-reldoc-dl-script branch from 995bca1 to 522fb56 Compare November 27, 2024 09:14
obnoxxx
obnoxxx approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tried it locally too with the version tag as cmgline arg.

two thoughts that can be addressed in follow-up changes:

  • put the script into the repo as an actual script under hack/
  • mention in the doc how to call it (version tag as first and only argument.

@mergify mergify bot merged commit 621cd84 into samba-in-kubernetes:master Nov 27, 2024
33 checks passed
@obnoxxx obnoxxx mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@obnoxxx obnoxxx obnoxxx approved these changes

@gd gd Awaiting requested review from gd

Assignees
No one assigned
Labels
priority-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phlogistonjohn @anoopcs9 @obnoxxx