common: implement an explicit preference order in sambacc installation

this explicitly implements a preference order for sambacc custom installation sources like so: local repo -> rpm -> wheeel -> copr. It makes the output a bit more verbose while at it. Signed-off-by: Michael Adam <[email protected]>
samba-in-kubernetes · Jan 10, 2025 · 3a2e16b · 3a2e16b
1 parent 21c22af
commit 3a2e16b
Showing 1 changed file with 31 additions and 17 deletions.
diff --git a/images/common/install-sambacc-common.sh b/images/common/install-sambacc-common.sh
@@ -30,28 +30,42 @@ install_sambacc() {
     done
 
 
-    local action=install-from-copr-repo
-    if [ "${#wheels[@]}" -gt 1 ]; then
-        echo "more than one wheel file found"
-        exit 1
-    elif [ "${#wheels[@]}" -eq 1 ]; then
-        action=install-wheel
+    local action="" 
+    echo "INFO: determining sambacc installation source." 
+    if [ "${#wheels[@]}" -gt 0 ]; then
+        echo "INFO: wheel found"
+        if [ "${#wheels[@]}" -gt 1 ]; then
+            echo "ERROR: more than one wheel file found"
+            exit 1
+        elif [ "${#wheels[@]}" -eq 1  ]; then
+            action=install-wheel
+        fi
     fi
-
-    if [ "${#rpmfiles[@]}" -gt 1 ]; then
-        echo "more than one sambacc rpm file found"
-        exit 1
-    elif [ "${#rpmfiles[@]}" -eq 1 ]; then
-        action=install-rpm
+    if [ "${#rpmfiles[@]}" -gt 0 ]; then
+        echo "INFO: rpm file found"
+        if [ "${#rpmfiles[@]}" -gt 1 ]; then
+            echo "ERROR: more than one sambacc rpm file found"
+            exit 1
+        elif [ "${#rpmfiles[@]}" -eq 1 ]; then
+            action=install-rpm
+        fi
     fi
+    if [ "${#repofiles[@]}" -gt 0 ]; then
+       echo  "INFO: repo file found"
+       if [ "${#repofiles[@]}" -gt 1 ]; then
+           echo "ERROR: more than one repo file found"
+           exit 1
+       elif [ "${#repofiles[@]}" -eq 1 ]; then
+           action=install-from-repo
+       fi
+    fi
+    if [ -z "${action}" ]; then
 
-    if [ "${#repofiles[@]}" -gt 1 ]; then
-        echo "more than one repo file found"
-        exit 1
-    elif [ "${#repofiles[@]}" -eq 1 ]; then
-        action=install-from-repo
+        echo "INFO: no local sambacc installation source found. falling back to copr install."
+        action=install-from-copr-repo
     fi
 
+    echo "INFO: selected installation method: '${action}'"
     if [ -z "${DEFAULT_JSON_FILE}" ]; then
         echo "DEFAULT_JSON_FILE value unset"
         exit 1