Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EICAS improvements #135

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

EICAS improvements #135

wants to merge 36 commits into from

Conversation

boufogre
Copy link
Contributor

@boufogre boufogre commented Jan 26, 2021 •
edited
Loading

Idle N2 calculation based on air density:

  • Idle N2 will now vary according to ambient air density

Basic AUTORELIGHT implementation:

  • if N2 gets below idle value, AUTORELIGHT indication will appear

EGT gauge rework:

  • Correct values for ground start limit or inflight start limit will be displayed
  • Correct maximum continuous and take-off limits
  • Maximum value indicated by the gauge no longer limited to 1000°C

@boufogre
AUTORELIGHT and Idle N2
36cd697 
Basic AUTORELIGHT implementation:
if N2 gets below idle value, AUTORELIGHT indication will appear

Idle N2 calculation based on air density:
Idle N2 will now vary according to ambient air density
@boufogre boufogre changed the title AUTORELIGHT and Idle N2 EICAS improvements Jan 26, 2021
@boufogre boufogre marked this pull request as draft January 26, 2021 20:25
@boufogre
EGT gauge modifications
4989987 
EGT gauge now display correct values
@boufogre
better idle N2 calculation
5bec0b3 
Better approximation
@boufogre
Many changes
11310b8 
Many changes
@boufogre
NaN init value for assumed temp
23deba4
@boufogre
TMA changes
d5062c7 
Thrust Mode Annunciator should now display the correct thrust mode, when selected in the FMC thrust limit page
@boufogre boufogre marked this pull request as ready for review February 22, 2021 09:56
ninjomcs
ninjomcs requested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@ninjomcs ninjomcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting needs to be fixed (applies to all of the code)

@boufogre boufogre marked this pull request as draft March 1, 2021 19:18
@boufogre boufogre marked this pull request as ready for review March 4, 2021 15:58
@boufogre boufogre requested a review from ninjomcs March 4, 2021 15:59
@boufogre
Copy link
Contributor Author

boufogre commented Mar 4, 2021

This time, I think it should be okay for review

@ninjomcs
Copy link
Contributor

ninjomcs commented Mar 6, 2021

i'm afraid there are still quite a bit of formatting errors

ninjomcs
ninjomcs reviewed Mar 19, 2021
View reviewed changes
html_ui/Pages/VCockpit/Instruments/Airliners/B747_8/EICAS/B747_8_EICAS.js Outdated
Comment on lines 138 to 140
case B747_8_EngineState.AUTOSTART:
if (this.getFuelValveOpen(i + 1)) {
if (N2Value >= this.getN2IdleValue()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still formatting errors here and there unfortunately, this for example is not indented correctly

@boufogre boufogre marked this pull request as draft April 19, 2021 14:58
@farhaddaudzai123 farhaddaudzai123 mentioned this pull request Jan 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjomcs ninjomcs ninjomcs requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boufogre @ninjomcs