isolated modules and almost isolated declarations #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isolatedModules
andisolatedDeclarations
provide guardrails that help make type checking faster / more portable. We don't actually need the flags enabled for our current build process / target, but it makes the code more portable if we decide to make changes in the future. And the code changes are pretty trivial, so I figured why not.Note that we can't actually enable the
isolatedDeclarations
flag because we use a symbol as a property key, but I've made all the other changes to be 99% compatible.tough-cookie/lib/cookie/cookie.ts
Line 548 in 8e39ae1