Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-10254698 integrate advance slack notifier #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions argusclient/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ class Notification(BaseEncodable):
:type name: str
:param notifierName: The name of the notifier implementation. Must be one of :attr:`EMAIL`, :attr:`AUDIT`,
:attr:`GOC`, :attr:`GUS`, :attr:`CALLBACK`, :attr:`PAGER_DUTY`, :attr:`REFOCUS_BOOLEAN`,
:attr:`REFOCUS_VALUE`, :attr:`SLACK`, :attr:`ALERT_ROUTER`
:attr:`REFOCUS_VALUE`, :attr:`SLACK`, :attr:`ALERT_ROUTER`, :attr:`ADVANCE_SLACK`
:type notifierName or notifier: str

**Optional parameters to the constructor:**
Expand Down Expand Up @@ -471,10 +471,11 @@ class Notification(BaseEncodable):
REFOCUS_VALUE = "com.salesforce.dva.argus.service.alert.notifier.RefocusValueNotifier"
SLACK = "com.salesforce.dva.argus.service.alert.notifier.SlackNotifier"
ALERT_ROUTER = "com.salesforce.dva.argus.service.alert.notifier.AlertRouterNotifier"
ADVANCE_SLACK = "com.salesforce.dva.argus.service.alert.notifier.AdvanceSlackNotifier"

#: Set of all valid notifier implementation names.
VALID_NOTIFIERS = frozenset((EMAIL, AUDIT, GOC, GUS, CALLBACK, PAGER_DUTY,
REFOCUS_BOOLEAN, REFOCUS_VALUE, SLACK, ALERT_ROUTER))
REFOCUS_BOOLEAN, REFOCUS_VALUE, SLACK, ALERT_ROUTER, ADVANCE_SLACK))

def __init__(self, name, notifierName=None, metricsToAnnotate=None, **kwargs):
notifierName = notifierName or kwargs.get('notifier')
Expand Down