Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-9746696 refresh token logic for falcon added #36

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

@W-9746696 refresh token logic for falcon added #36

wants to merge 7 commits into from

Conversation

vmeena0418
Copy link
Collaborator

No description provided.

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @vmeena0418 is an internal user so signing the CLA is not required. However, we need to confirm this.

j-ma-sf
j-ma-sf reviewed Aug 27, 2021
View reviewed changes
argusclient/client.py Outdated Show resolved Hide resolved
j-ma-sf
j-ma-sf reviewed Aug 27, 2021
View reviewed changes
argusclient/client.py Outdated Show resolved Hide resolved
j-ma-sf
j-ma-sf reviewed Aug 27, 2021
View reviewed changes
argusclient/client.py Outdated Show resolved Hide resolved
j-ma-sf
j-ma-sf reviewed Aug 27, 2021
View reviewed changes
argusclient/client.py Outdated Show resolved Hide resolved
j-ma-sf
j-ma-sf reviewed Aug 27, 2021
View reviewed changes
argusclient/client.py Outdated
@@ -712,6 +715,18 @@ def with_auth_token(*args, **kwargs):

return with_auth_token

# Updates Access token and refresh token from files for mac to falcon usecase
def getTokensFromFiles():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def getTokensFromFiles():
def promptForTokens():

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update method calls as well

@hdara-sfdc hdara-sfdc marked this pull request as draft September 27, 2021 13:30
@hdara-sfdc
Copy link
Contributor

@vmeena0418 Please remove venv and any other files that are not supposed to be added to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-ma-sf j-ma-sf j-ma-sf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla:missing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmeena0418 @hdara-sfdc @j-ma-sf