Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voucher validation when discount type is shipping #5441

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

poulch
Copy link
Member

@poulch poulch commented Feb 27, 2025

Scope of the change

Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 158bb2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.34%. Comparing base (5e62013) to head (158bb2a).

Files with missing lines Patch % Lines
src/discounts/handlers.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5441      +/-   ##
==========================================
+ Coverage   62.32%   62.34%   +0.02%     
==========================================
  Files        1271     1271              
  Lines       22092    22098       +6     
  Branches     4616     4617       +1     
==========================================
+ Hits        13768    13778      +10     
+ Misses       8285     8281       -4     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-5441 February 27, 2025 10:05 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5441 February 27, 2025 18:27 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant