Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to v20 #5438

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Update Node to v20 #5438

wants to merge 9 commits into from

Conversation

witoszekdev
Copy link
Member

Scope of the change

This PR updates node to version 20

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: f0c9fb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
BlueOak-1.0.0 1
Packages
  • path-scurry
CC0-1.0 1
Packages
  • type-fest
MIT/X11 1
Packages
  • nub
MPL-1.1 1
Packages
  • harmony-reflect
MPL-2.0 1
Packages
  • dompurify
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
WTFPL 1
Packages
  • opener
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
<<missing>> 3
Packages
  • busboy
  • saleor-dashboard
  • streamsearch
BSD-2-Clause 24
Packages
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • browser-process-hrtime
  • css-select
  • css-what
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • nth-check
  • stringify-object
  • And 4 more...
BSD-3-Clause 45
Packages
  • @humanwhocodes/object-schema
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • @sinonjs/commons
  • @sinonjs/fake-timers
  • abab
  • asn1js
  • babel-plugin-istanbul
  • charenc
  • chroma-js
  • crypt
  • diff
  • esquery
  • exenv
  • And 25 more...
Apache-2.0 46
Packages
  • @ampproject/remapping
  • @editorjs/editorjs
  • @humanwhocodes/config-array
  • @humanwhocodes/module-importer
  • @opentelemetry/api
  • @opentelemetry/semantic-conventions
  • @playwright/test
  • @swc/core
  • @swc/core-darwin-arm64
  • @swc/core-darwin-x64
  • @swc/core-linux-arm-gnueabihf
  • @swc/core-linux-arm64-gnu
  • @swc/core-linux-arm64-musl
  • @swc/core-linux-x64-gnu
  • @swc/core-linux-x64-musl
  • @swc/core-win32-arm64-msvc
  • @swc/core-win32-ia32-msvc
  • @swc/core-win32-x64-msvc
  • @swc/counter
  • aria-query
  • And 26 more...
ISC 50
Packages
  • @esbuild-plugins/node-globals-polyfill
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • anymatch
  • boolbase
  • browser-stdout
  • cli-width
  • cliui
  • electron-to-chromium
  • fastq
  • flatted
  • fs.realpath
  • get-caller-file
  • get-own-enumerable-property-symbols
  • glob
  • glob-parent
  • graceful-fs
  • inflight
  • inherits
  • ini
  • And 30 more...
MIT 1124
Packages
  • @adobe/css-tools
  • @apollo/client
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • @babel/helper-simple-access
  • @babel/helper-skip-transparent-expression-wrappers
  • @babel/helper-string-parser
  • And 1104 more...

@github-actions github-actions bot temporarily deployed to pr-5438 February 25, 2025 17:23 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5438 February 26, 2025 11:58 Destroyed
Copy link

github-actions bot commented Feb 26, 2025

merge-reports: Run #4691

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 4m54s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@krzysztofwolski
Copy link
Member

I know it's still a draft, but don't forget about the dockerfile and readme :) Easy to miss those two:

CI test workflow seems to be pulling version from .rc file, but might be worth double checking there.

Spring cleaning so early this year, love it :D

@github-actions github-actions bot temporarily deployed to pr-5438 February 27, 2025 11:49 Destroyed
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.34%. Comparing base (17ff578) to head (f0c9fb1).

Files with missing lines Patch % Lines
src/components/Money/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5438      +/-   ##
==========================================
- Coverage   62.35%   62.34%   -0.01%     
==========================================
  Files        1276     1276              
  Lines       22135    22135              
  Branches     4399     4399              
==========================================
- Hits        13802    13800       -2     
- Misses       8294     8296       +2     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@witoszekdev
Copy link
Member Author

Thanks @krzysztofwolski ❤️

@github-actions github-actions bot temporarily deployed to pr-5438 February 27, 2025 11:59 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants