-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use # in tests tags #5379
Merged
Merged
Use # in tests tags #5379
+162
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab2f779 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Differences Found✅ No packages or licenses were added. SummaryExpand
|
b243de5
to
8638cf2
Compare
8638cf2
to
43407b2
Compare
43407b2
to
256f2c5
Compare
256f2c5
to
f0c5ef6
Compare
This was referenced Feb 3, 2025
f0c5ef6
to
5af7886
Compare
5af7886
to
e12bba7
Compare
michalina-graczyk
previously approved these changes
Feb 4, 2025
e12bba7
to
581f6e3
Compare
Summary
Failed TestsNo failed tests ✨ 🔄 This comment has been updated |
add changeset
581f6e3
to
ab2f779
Compare
michalina-graczyk
approved these changes
Feb 5, 2025
andrzejewsky
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the change
While working on adding PR reporting for test results, we realized that our test tags match the GitHub usernames of actual users. This unintentionally mentions them in reports, which is not ideal.
![image](https://private-user-images.githubusercontent.com/30683248/409991541-4a318acf-bb09-4350-bea2-e7951f7d4eb6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NTIzOTYsIm5iZiI6MTczODk1MjA5NiwicGF0aCI6Ii8zMDY4MzI0OC80MDk5OTE1NDEtNGEzMThhY2YtYmIwOS00MzUwLWJlYTItZTc5NTFmN2Q0ZWI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE4MTQ1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlYzY0MTFkYjNiNGE1NzU1ZjQxNzM1NzdmYmJiMzNjMDkxMDhiOWMwY2YzMmFjYzFmZjc4YThiMGEwMmFhNmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mlImDGRIaRtcCDVZX2-1YZkFlrwNpB7SOin2s1gLdEg)
Internal task: https://linear.app/saleor/issue/QA-282/
It should be merged along with:
#5382
#5383