Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use # in tests tags #5379

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Use # in tests tags #5379

merged 1 commit into from
Feb 5, 2025

Conversation

szczecha
Copy link
Member

@szczecha szczecha commented Jan 29, 2025

Scope of the change

While working on adding PR reporting for test results, we realized that our test tags match the GitHub usernames of actual users. This unintentionally mentions them in reports, which is not ideal.
image

Internal task: https://linear.app/saleor/issue/QA-282/

It should be merged along with:
#5382
#5383

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: ab2f779

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5379 January 29, 2025 14:40 Destroyed
Copy link

github-actions bot commented Jan 29, 2025

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
BlueOak-1.0.0 1
Packages
  • path-scurry
CC0-1.0 1
Packages
  • type-fest
MIT/X11 1
Packages
  • nub
MPL-1.1 1
Packages
  • harmony-reflect
MPL-2.0 1
Packages
  • dompurify
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
WTFPL 1
Packages
  • opener
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
<<missing>> 3
Packages
  • busboy
  • saleor-dashboard
  • streamsearch
BSD-2-Clause 24
Packages
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • browser-process-hrtime
  • css-select
  • css-what
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • nth-check
  • stringify-object
  • And 4 more...
BSD-3-Clause 45
Packages
  • @humanwhocodes/object-schema
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • @sinonjs/commons
  • @sinonjs/fake-timers
  • abab
  • asn1js
  • babel-plugin-istanbul
  • charenc
  • chroma-js
  • crypt
  • diff
  • esquery
  • exenv
  • And 25 more...
Apache-2.0 46
Packages
  • @ampproject/remapping
  • @editorjs/editorjs
  • @humanwhocodes/config-array
  • @humanwhocodes/module-importer
  • @opentelemetry/api
  • @opentelemetry/semantic-conventions
  • @playwright/test
  • @swc/core
  • @swc/core-darwin-arm64
  • @swc/core-darwin-x64
  • @swc/core-linux-arm-gnueabihf
  • @swc/core-linux-arm64-gnu
  • @swc/core-linux-arm64-musl
  • @swc/core-linux-x64-gnu
  • @swc/core-linux-x64-musl
  • @swc/core-win32-arm64-msvc
  • @swc/core-win32-ia32-msvc
  • @swc/core-win32-x64-msvc
  • @swc/counter
  • aria-query
  • And 26 more...
ISC 50
Packages
  • @esbuild-plugins/node-globals-polyfill
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • anymatch
  • boolbase
  • browser-stdout
  • cli-width
  • cliui
  • electron-to-chromium
  • fastq
  • flatted
  • fs.realpath
  • get-caller-file
  • get-own-enumerable-property-symbols
  • glob
  • glob-parent
  • graceful-fs
  • inflight
  • inherits
  • ini
  • And 30 more...
MIT 1124
Packages
  • @adobe/css-tools
  • @apollo/client
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • @babel/helper-simple-access
  • @babel/helper-skip-transparent-expression-wrappers
  • @babel/helper-string-parser
  • And 1104 more...

@github-actions github-actions bot temporarily deployed to pr-5379 January 29, 2025 15:30 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from b243de5 to 8638cf2 Compare January 30, 2025 10:47
@github-actions github-actions bot temporarily deployed to pr-5379 January 30, 2025 10:49 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from 8638cf2 to 43407b2 Compare January 30, 2025 13:21
@github-actions github-actions bot temporarily deployed to pr-5379 January 30, 2025 13:25 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from 43407b2 to 256f2c5 Compare January 31, 2025 13:47
@github-actions github-actions bot temporarily deployed to pr-5379 January 31, 2025 13:50 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from 256f2c5 to f0c5ef6 Compare February 3, 2025 08:03
@szczecha szczecha marked this pull request as ready for review February 3, 2025 08:04
@szczecha szczecha requested a review from a team as a code owner February 3, 2025 08:04
This was referenced Feb 3, 2025
@github-actions github-actions bot temporarily deployed to pr-5379 February 3, 2025 08:07 Destroyed
@szczecha szczecha requested a review from a team February 3, 2025 09:01
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from f0c5ef6 to 5af7886 Compare February 3, 2025 13:09
@github-actions github-actions bot temporarily deployed to pr-5379 February 3, 2025 13:11 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from 5af7886 to e12bba7 Compare February 3, 2025 14:23
@github-actions github-actions bot temporarily deployed to pr-5379 February 3, 2025 14:28 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from e12bba7 to 581f6e3 Compare February 5, 2025 11:56
@github-actions github-actions bot temporarily deployed to pr-5379 February 5, 2025 11:59 Destroyed
Copy link

github-actions bot commented Feb 5, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 235 0 0 0 0 0 5m16s

Failed Tests

No failed tests ✨

Github Test Reporter

🔄 This comment has been updated

@github-actions github-actions bot temporarily deployed to pr-5379 February 5, 2025 12:57 Destroyed
@szczecha szczecha force-pushed the qa-282-replace-tags-in-tests branch from 581f6e3 to ab2f779 Compare February 5, 2025 13:11
@szczecha szczecha merged commit d87fab0 into main Feb 5, 2025
22 of 24 checks passed
@szczecha szczecha deleted the qa-282-replace-tags-in-tests branch February 5, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants