Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid opens in new tab when click with cmd button #5378

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Datagrid opens in new tab when click with cmd button #5378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1679308
Datagrid opens in new tab when click with cmd button
poulch Jan 28, 2025
abad5ea
Add changeset
poulch Jan 28, 2025
3323c33
Shorten code
poulch Jan 28, 2025
2374461
Merge branch 'main' into bck-1295-cmd-datagrid-click
poulch Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/new-monkeys-talk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

You can now open datagrid list item in new tab using cmd/ctrl button
8 changes: 7 additions & 1 deletion src/components/Datagrid/Datagrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,13 @@ export const Datagrid: React.FC<DatagridProps> = ({
e.preventDefault();

if (e.currentTarget.dataset.reactRouterPath) {
navigate(e.currentTarget.dataset.reactRouterPath, navigatorOpts);
const url = e.currentTarget.dataset.reactRouterPath;

if (e.metaKey || e.ctrlKey) {
window.open(url, "_blank");
} else {
navigate(url, navigatorOpts);
}
}
}}
/>
Expand Down
Loading