Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum length for plain text attributes #5339

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

peelar
Copy link
Member

@peelar peelar commented Jan 8, 2025

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Have you written tests?

  • Yes!

[Optional] Description

Dashboard crashes when the value of the attribute plainText is too long. However, the currently set limit is too short. I want to increase it to 10000 characters

@peelar peelar self-assigned this Jan 8, 2025
@peelar peelar requested a review from a team as a code owner January 8, 2025 13:02
@peelar peelar requested review from Cloud11PL and poulch January 8, 2025 13:02
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 3924e75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5339 January 8, 2025 13:09 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5339 January 8, 2025 13:42 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5339 January 8, 2025 14:08 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5339 January 8, 2025 14:40 Destroyed
@poulch poulch merged commit c172418 into main Jan 9, 2025
11 of 12 checks passed
@poulch poulch deleted the merx-1380-change-truncate-limit branch January 9, 2025 09:14
poulch pushed a commit that referenced this pull request Jan 9, 2025
* Increase maximum length for plain text attributes

* add changeset

* cleanup

---------

Co-authored-by: Wojciech Mista <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants