Fix identify users in analytics #5335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,8 +83,6 @@ export function useAuthProvider({ intl, notify, apolloClient }: UseAuthProviderO | |||
| } | |||
| }; | |||
| const handleLogout = async () => { | |||
| analytics.reset(); | |||
There was a problem hiding this comment.
Question: how it will work now? We won't reset user if they are logging out?
There was a problem hiding this comment.
We don't use our user_id to identify users so we rely on an auto-generated ID by Posthog, so when we run reset on logout and user login again, a new ID was generated.
For now, we will have one ID per device and only change the domain and email domain by setting user properties.
Cloud11PL
previously approved these changes
Jan 7, 2025
🦋 Changeset detectedLatest commit: 441a867 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-dashboard into merx-1364-fix-posthog-auth
andrzejewsky
approved these changes
Jan 16, 2025
poulch
added a commit
that referenced
this pull request
Jan 16, 2025
* Fix identify users in analytics * Add changeset * Restore IS_CLOUD_INSTANCE from env * Track and set user properties * Detect when user properties change and set only then * Fix isCloudInstance * Update ls data and add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description