Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order filtering by the metadata #5331

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Conversation

andrzejewsky
Copy link
Member

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Dec 31, 2024

🦋 Changeset detected

Latest commit: ced98be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5331 December 31, 2024 14:15 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 2, 2025 13:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 2, 2025 14:22 Destroyed
@andrzejewsky andrzejewsky marked this pull request as ready for review January 3, 2025 11:28
@andrzejewsky andrzejewsky requested a review from a team as a code owner January 3, 2025 11:28
@andrzejewsky andrzejewsky requested a review from Cloud11PL January 3, 2025 11:29
@github-actions github-actions bot temporarily deployed to pr-5331 January 3, 2025 11:31 Destroyed
Cloud11PL
Cloud11PL previously approved these changes Jan 3, 2025
emitter.blurRightOperator(index);
}}
error={error}
placeholder="Key"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: I think we're missing translations here

@github-actions github-actions bot temporarily deployed to pr-5331 January 3, 2025 12:48 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 3, 2025 13:13 Destroyed
poulch
poulch previously approved these changes Jan 3, 2025
disabled: boolean;
}

export const MetadataInput = ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: WDYT about make this component more generic and name it like DoubleTextInput?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that in the beginning, but metadata is specific field so i wanted to create something dedicated to this, in case we need to change something just for metadata. Double text input makes sense, but... i cannot foresee what will be needed in the future and want to avoid latter on eg. TripleTextInput etc.

@github-actions github-actions bot temporarily deployed to pr-5331 January 7, 2025 12:31 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 8, 2025 10:26 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 8, 2025 10:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 8, 2025 10:44 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5331 January 8, 2025 12:40 Destroyed
@andrzejewsky andrzejewsky merged commit 5b8c8b0 into main Jan 8, 2025
14 of 15 checks passed
@andrzejewsky andrzejewsky deleted the merx-1336-order-metadata-filtering branch January 8, 2025 14:04
poulch added a commit that referenced this pull request Jan 8, 2025
* Metadata filter

* Fix styling

* Fix styling

* Fix tuples

* Fix pagination

* Translations

* Extract messages

---------

Co-authored-by: Paweł Chyła <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants