-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order filtering by the metadata #5331
Conversation
🦋 Changeset detectedLatest commit: ced98be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emitter.blurRightOperator(index); | ||
}} | ||
error={error} | ||
placeholder="Key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think we're missing translations here
disabled: boolean; | ||
} | ||
|
||
export const MetadataInput = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: WDYT about make this component more generic and name it like DoubleTextInput?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that in the beginning, but metadata is specific field so i wanted to create something dedicated to this, in case we need to change something just for metadata. Double text input makes sense, but... i cannot foresee what will be needed in the future and want to avoid latter on eg. TripleTextInput etc.
* Metadata filter * Fix styling * Fix styling * Fix tuples * Fix pagination * Translations * Extract messages --------- Co-authored-by: Paweł Chyła <[email protected]>
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description