Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering products in collection #5327

Merged
merged 25 commits into from
Jan 31, 2025

Conversation

andrzejewsky
Copy link
Member

@andrzejewsky andrzejewsky commented Dec 19, 2024

  • Added DnD reordering for products within a collection
  • Ability to change the items per page for these products
  • A bit of refactoring for fetching data, now separated query fetches the products itself which does no reload entire page when operating the products only (eg. when paginate)
demo.mov

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 7733062

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andrzejewsky
Copy link
Member Author

Waiting for core fix with ordering.

Copy link

github-actions bot commented Dec 19, 2024

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
BlueOak-1.0.0 1
Packages
  • path-scurry
CC0-1.0 1
Packages
  • type-fest
MIT/X11 1
Packages
  • nub
MPL-1.1 1
Packages
  • harmony-reflect
MPL-2.0 1
Packages
  • dompurify
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
WTFPL 1
Packages
  • opener
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
<<missing>> 3
Packages
  • busboy
  • saleor-dashboard
  • streamsearch
BSD-2-Clause 24
Packages
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • browser-process-hrtime
  • css-select
  • css-what
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • esutils
  • nth-check
  • stringify-object
  • And 4 more...
BSD-3-Clause 45
Packages
  • @humanwhocodes/object-schema
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • @sinonjs/commons
  • @sinonjs/fake-timers
  • abab
  • asn1js
  • babel-plugin-istanbul
  • charenc
  • chroma-js
  • crypt
  • diff
  • esquery
  • exenv
  • And 25 more...
Apache-2.0 46
Packages
  • @ampproject/remapping
  • @editorjs/editorjs
  • @humanwhocodes/config-array
  • @humanwhocodes/module-importer
  • @opentelemetry/api
  • @opentelemetry/semantic-conventions
  • @playwright/test
  • @swc/core
  • @swc/core-darwin-arm64
  • @swc/core-darwin-x64
  • @swc/core-linux-arm-gnueabihf
  • @swc/core-linux-arm64-gnu
  • @swc/core-linux-arm64-musl
  • @swc/core-linux-x64-gnu
  • @swc/core-linux-x64-musl
  • @swc/core-win32-arm64-msvc
  • @swc/core-win32-ia32-msvc
  • @swc/core-win32-x64-msvc
  • @swc/counter
  • aria-query
  • And 26 more...
ISC 50
Packages
  • @esbuild-plugins/node-globals-polyfill
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • anymatch
  • boolbase
  • browser-stdout
  • cli-width
  • cliui
  • electron-to-chromium
  • fastq
  • flatted
  • fs.realpath
  • get-caller-file
  • get-own-enumerable-property-symbols
  • glob
  • glob-parent
  • graceful-fs
  • inflight
  • inherits
  • ini
  • And 30 more...
MIT 1123
Packages
  • @adobe/css-tools
  • @apollo/client
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @babel/code-frame
  • @babel/compat-data
  • @babel/core
  • @babel/generator
  • @babel/helper-annotate-as-pure
  • @babel/helper-compilation-targets
  • @babel/helper-create-class-features-plugin
  • @babel/helper-member-expression-to-functions
  • @babel/helper-module-imports
  • @babel/helper-module-transforms
  • @babel/helper-optimise-call-expression
  • @babel/helper-plugin-utils
  • @babel/helper-replace-supers
  • @babel/helper-simple-access
  • @babel/helper-skip-transparent-expression-wrappers
  • @babel/helper-string-parser
  • And 1103 more...

@github-actions github-actions bot temporarily deployed to pr-5327 December 19, 2024 15:36 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5327 December 23, 2024 11:51 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5327 December 23, 2024 12:37 Destroyed
Copy link

github-actions bot commented Jan 7, 2025

This pull request is stale because it has been open 14 days with no activity.

@github-actions github-actions bot added the stale label Jan 7, 2025
Copy link

github-actions bot commented Jan 9, 2025

This PR request has been closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team

@github-actions github-actions bot closed this Jan 9, 2025
@andrzejewsky andrzejewsky reopened this Jan 17, 2025
@github-actions github-actions bot temporarily deployed to pr-5327 January 17, 2025 10:02 Destroyed
@andrzejewsky andrzejewsky marked this pull request as ready for review January 17, 2025 15:53
@andrzejewsky andrzejewsky requested a review from a team as a code owner January 17, 2025 15:53
@andrzejewsky andrzejewsky requested review from Cloud11PL and removed request for lkostrowski January 17, 2025 15:53
@github-actions github-actions bot temporarily deployed to pr-5327 January 17, 2025 15:54 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5327 January 20, 2025 14:24 Destroyed
poulch
poulch previously approved these changes Jan 30, 2025
@andrzejewsky andrzejewsky dismissed stale reviews from Cloud11PL and poulch via 0b5edde January 30, 2025 12:31
Cloud11PL
Cloud11PL previously approved these changes Jan 30, 2025
@github-actions github-actions bot temporarily deployed to pr-5327 January 30, 2025 12:33 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5327 January 30, 2025 12:58 Destroyed
poulch
poulch previously approved these changes Jan 30, 2025
@github-actions github-actions bot temporarily deployed to pr-5327 January 30, 2025 13:42 Destroyed
Cloud11PL
Cloud11PL previously approved these changes Jan 30, 2025
@andrzejewsky andrzejewsky dismissed stale reviews from Cloud11PL and poulch via c271543 January 30, 2025 15:52
@github-actions github-actions bot temporarily deployed to pr-5327 January 30, 2025 15:55 Destroyed
poulch
poulch previously approved these changes Jan 30, 2025
@github-actions github-actions bot temporarily deployed to pr-5327 January 31, 2025 09:50 Destroyed
@andrzejewsky andrzejewsky merged commit d01a207 into main Jan 31, 2025
20 checks passed
@andrzejewsky andrzejewsky deleted the merx-1329-collection-products-reorder branch January 31, 2025 10:53
poulch pushed a commit that referenced this pull request Jan 31, 2025
* Reordering products in collection

* Fix collectionId

* Fix quering

* Tests, translations

* Tests, translations

* Tests, translations

* Fix pagination state, use collectionId

* Fix pagination state, use collectionId

* D&d

* Update tests

* Update tests

* Update tests

* Update translations

* Update tests

* Fix initial load

* Cr

* Empty image

* Lint

* Display pagination when there are no elements

* Add mutation workaround

* Test fix

* Test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants