Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit waits for draft order shipping carrier button interaction #5324

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Add explicit waits for draft order shipping carrier button interaction #5324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d9aad4
Add explicit waits for draft order shipping carrier button interaction
michalina-graczyk Dec 17, 2024
ceca6d1
Merge branch 'main' into MERX-1370-saleor_84-improvment
michalina-graczyk Dec 18, 2024
caa80b6
Add fixes from review
michalina-graczyk Dec 18, 2024
3899cf2
Merge branch 'main' into MERX-1370-saleor_84-improvment
michalina-graczyk Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thin-drinks-kneel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Add explicit waits for draft order shipping carrier button interaction
2 changes: 2 additions & 0 deletions playwright/pages/draftOrdersPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ export class DraftOrdersPage extends BasePage {
}

async clickAddShippingCarrierButton() {
await this.addShippingCarrierLink.scrollIntoViewIfNeeded();
await this.addShippingCarrierLink.click();

await this.waitForDOMToFullyLoad();
}

Expand Down
8 changes: 7 additions & 1 deletion playwright/tests/orders.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,15 @@ test("TC: SALEOR_84 Create draft order @e2e @draft", async () => {
await draftOrdersPage.expectSuccessBanner();
await draftOrdersPage.addressDialog.clickConfirmButton();
await draftOrdersPage.expectSuccessBanner();

await draftOrdersPage.addShippingCarrierLink.waitFor({ state: "visible" });
// Ensure the button is in viewport before clicking
await draftOrdersPage.addShippingCarrierLink.scrollIntoViewIfNeeded();

await expect(draftOrdersPage.addShippingCarrierLink).toBeVisible();
await draftOrdersPage.clickAddShippingCarrierButton();

await draftOrdersPage.shippingAddressDialog.pickAndConfirmFirstShippingMethod();
//await draftOrdersPage.expectSuccessBanner();
await draftOrdersPage.clickFinalizeButton();
await draftOrdersPage.expectSuccessBanner({ message: "finalized" });
});
Expand Down
Loading