Improve test functionality - SALEOR_215 #5255
Conversation
🦋 Changeset detectedLatest commit: 2904632 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const calculateDiscountedPrice = ( | ||
| undiscountedPrice: number, | ||
| discountPercentage: number, | ||
| ): number => { | ||
| return undiscountedPrice - (undiscountedPrice * discountPercentage) / 100; | ||
| }; |
There was a problem hiding this comment.
This is dangerous: you just create a code to test the code. It implements the way discount is being calculated, meaning the test now is aware of it while it should not. Everywhere when possible make assertions on real values, because the incoming data is always known (you know what prices given product has because it's test data)
Non, blocking for now, but please keep in mind that.
.changeset/violet-laws-hang.md
Outdated
| "saleor-dashboard": patch | ||
| --- | ||
|
|
||
| Improve inline discount test precision and reliability in draft orders |
There was a problem hiding this comment.
Please write changeset where you clearly explain what you have improved. Something like
Now, test that checks discount calculation asserts against fixed precision (2 decimals)
michalina-graczyk
changed the title
michalina-graczyk
dismissed stale reviews from szczecha and andrzejewsky
via
0688cfc
* Improve test functionality * add changset * improved changeset * Add more details to changeset * remove unnecessery line * empty commit
* Improve test functionality * add changset * improved changeset * Add more details to changeset * remove unnecessery line * empty commit
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description