Fix anchor in datagrid-based lists #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68c82af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
poulch
approved these changes
Nov 13, 2024
andrzejewsky
approved these changes
Nov 18, 2024
| @@ -120,6 +119,7 @@ export const AttributeListDatagrid = ({ | |||
| onToggle={handlers.onToggle} | |||
| /> | |||
| )} | |||
| navigatorOpts={{ state: getPrevLocationState(location) }} | |||
There was a problem hiding this comment.
if this is repeated across each view with the gridd, can just grid call useLocation inside of its component?
There was a problem hiding this comment.
I was thinking about it but I think I would rather have opts like that controlled outside of <Datagrid /> component.
poulch
pushed a commit
that referenced
this pull request
Nov 19, 2024
Co-authored-by: M.Graczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onClickof the<a />anchor is now executed instead of Datagrid'sonRowClickthen it adds missingnavigatorOptsto Datagrid lists allowing them to preserve state of the previous location so that the backlink redirects to list with pagination and filtersWhat type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description