[QA] Fix tests for SALEOR_1801, SALEOR_1802 & SALEOR_3002 #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87b37b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- product being available in search - product variant being set to onSale Resolves issues with - Unable to find product while assigning from discounts - Checking discounted value too quickly before the sale got processed.
github-actions
bot
temporarily deployed
to
storybook pr-fix-tests-for-1801-1802
github-actions
bot
temporarily deployed
to
storybook pr-fix-tests-for-1801-1802
michalina-graczyk
requested review from
a team,
andrzejewsky and
poulch
and removed request for
a team
michalina-graczyk
changed the title
github-actions
bot
temporarily deployed
to
storybook pr-fix-tests-for-1801-1802
michalina-graczyk
changed the title
michalina-graczyk
changed the title
andrzejewsky
approved these changes
May 13, 2024
yellowee
suggested changes
May 14, 2024
| */ | ||
| cy.visit(urlList.sales); | ||
| createSale({ | ||
| saleName, | ||
| channelName: channel.name, | ||
| discountValue, | ||
| }); | ||
| // Make sure the product is searchable before assigning |
There was a problem hiding this comment.
Suggestion: Remove unnecessary comments
There was a problem hiding this comment.
Tbh I left it intentionally, it is easier to read the code but I can remove it
| @@ -146,6 +146,7 @@ describe("As a staff user I want to manage apps", () => { | |||
| .click() | |||
| .get(BUTTON_SELECTORS.confirm) | |||
| .click() | |||
| .wait(3000) | |||
There was a problem hiding this comment.
I thought that we've agreed to not add explicit waits and instead we should wait for a specific action/element.
There was a problem hiding this comment.
yes but in this case, we want to make it work. It is Cypress that we are removing, it is a temporary quick solution
| throw new Error( | ||
| `Product with name ${productName} is not visible in search results. Retried for ${retries} times`, | ||
| `Product with name ${productName} is not visible in search results. Retried for ${maxRetries} times`, | ||
| ); | ||
| } else { | ||
| cy.wait(5000); |
There was a problem hiding this comment.
this one was before my changes
andrzejewsky
approved these changes
May 14, 2024
michalina-graczyk
added a commit
that referenced
this pull request
May 15, 2024
* Add fixes * WIP * wip * Added waiting for: - product being available in search - product variant being set to onSale Resolves issues with - Unable to find product while assigning from discounts - Checking discounted value too quickly before the sale got processed. * Revert package-lock.json * Add missing LB * Add changeset * Add quick fix for SALEOR_3002 --------- Co-authored-by: wojteknowacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description