[TEST] [E2E] Delete shipping rate from its details page #4625
Conversation
🦋 Changeset detectedLatest commit: 3f2bca7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yellowee
force-pushed
the
test_delete_shipping_method
branch
2 times, most recently
from
d9e3db9 to
e2ff683
Compare
yellowee
force-pushed
the
test_delete_shipping_method
branch
from
e2ff683 to
7a2a545
Compare
yellowee
force-pushed
the
test_delete_shipping_method
branch
from
7a2a545 to
2e6e33c
Compare
yellowee
requested review from
a team,
andrzejewsky and
poulch
and removed request for
andrzejewsky and
poulch
yellowee
force-pushed
the
test_delete_shipping_method
branch
from
2e6e33c to
5aa0cb7
Compare
| async clickDeleteShippingMethod() { | ||
| await this.priceBasedRatesSection.locator(this.deleteShippingMethodButton).click(); | ||
| async clickDeleteShippingRateFromTheList() { | ||
| await this.priceBasedRatesSection.locator(this.deleteShippingRateButtonOnList).click(); |
There was a problem hiding this comment.
Is this not gonna be confusing when deleting weight base shipping?
There was a problem hiding this comment.
Would clickDeletePriceBasedShippingMethod be more obvious and descriptive?
| const weightBasedRate = SHIPPING_METHODS.shippingMethodWithRatesToBeDeleted.rates.weightBasedRateToBeDeleted.name; | ||
|
|
||
| await shippingMethodsPage.gotoExistingShippingRate(shippingMethodId, shippingRateId); | ||
| await expect(shippingMethodsPage.basePage.pageHeader).toBeVisible(); |
There was a problem hiding this comment.
Since you await input to be visible inside gotoExistingShippingRate then this expect has no use, right?
| await shippingMethodsPage.gotoExistingShippingMethod( | ||
| SHIPPING_METHODS.shippingMethodWithRatesToBeDeleted.id, | ||
| ); | ||
| await expect(shippingMethodsPage.weightBasedRatesSection).toContainText("No shipping rates found"); | ||
| await expect(shippingMethodsPage.weightBasedRatesSection).not.toContainText(weightBasedRate); |
There was a problem hiding this comment.
We do not check integration between views so I would skip navigating to other views to confirm the action result. Check all you need on the screen that was loaded after deletion, do not go to other views to double-check results. Otherwise, this test would not have an end, there are so many views to be checked
| page, | ||
| }) => { | ||
| const shippingMethodsPage = new ShippingMethodsPage(page); | ||
| const shippingMethodId = SHIPPING_METHODS.shippingMethodWithRatesToBeDeleted.id; |
There was a problem hiding this comment.
Just to clarify, this ID is actually the Shipping Zone ID and not the Shipping Method ID.
It covers TC SALEOR_35
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description