-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug #4569 #4571
Fix Bug #4569 #4571
Conversation
🦋 Changeset detectedLatest commit: c335eee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@@ -1,7 +1,7 @@ | |||
FROM node:18-alpine as builder | |||
RUN apk --no-cache add bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need to install bash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically, we don't use sentry at all within the docker but the script is being executed even if it skips the sentry-related scripts. Ok let's keep the bash for now, will perhaps wok on some workaround later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal was to make a docker image build. I didn't want to interfere with the script. I left the script changes for other issues.
Hey @tgrycuk thanks for contribution! Please accept CLA + add the changeset file (as patch) |
* Fix Bug #4569 * add changeset * Update unable-to-build-docker-image .md --------- Co-authored-by: Tomasz Grycuk <[email protected]> Co-authored-by: Patryk Andrzejewski <[email protected]>
closes #4569
After some minor changes, building the docker image works.
Screenshots
Pull Request Checklist
data-test-id
are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=2