Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discount hasEndDate selector in tests #4555

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

poulch
Copy link
Member

@poulch poulch commented Dec 19, 2023

closes #...

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@poulch poulch requested review from a team, andrzejewsky and Droniu December 19, 2023 11:40
Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: a95d07e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@poulch poulch requested a review from wojteknowacki December 19, 2023 11:41
@github-actions github-actions bot temporarily deployed to storybook pr-fix-discount-end-date-test December 19, 2023 11:41 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-discount-end-date-test December 19, 2023 11:41 Destroyed
wojteknowacki
wojteknowacki previously approved these changes Dec 19, 2023
@github-actions github-actions bot temporarily deployed to pr-fix-discount-end-date-test December 19, 2023 11:44 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-discount-end-date-test December 19, 2023 11:44 Destroyed
@poulch poulch merged commit 9208b3e into main Dec 19, 2023
16 checks passed
@poulch poulch deleted the fix-discount-end-date-test branch December 19, 2023 12:15
poulch added a commit that referenced this pull request Dec 19, 2023
* Fix discount hasEndDate selector in tests

* Add changeset
Copy link

cypress bot commented Dec 19, 2023

2 failed tests on run #5948 ↗︎

2 240 7 2 Flakiness 0

Details:

Triggered via release - CORE 3.18.9-ef2084f,
Project: Saleor Commit: 6f7b2373db
Status: Failed Duration: 10:57 💡
Started: Jan 11, 2024 2:48 PM Ended: Jan 11, 2024 2:59 PM
Failed  apps.js • 1 failed test • UI - Electron

View Output

Test Artifacts
As a staff user I want to manage apps > should be able to create webhook. TC: SALEOR_3002 Screenshots
Failed  orders/transactionsForOrders.js • 1 failed test • UI - Electron

View Output

Test Artifacts
Orders > should mark order as paid. TC: 3901 Screenshots

Review all test suite changes for PR #4555 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants