Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the related cloud environment #4525

Merged
merged 20 commits into from
Dec 18, 2023
Merged

Add link to the related cloud environment #4525

merged 20 commits into from
Dec 18, 2023

Conversation

andrzejewsky
Copy link
Member

closes: #4449

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@andrzejewsky andrzejewsky requested review from a team, poulch and Droniu December 12, 2023 10:54
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: f92c876

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-environment-link December 12, 2023 10:54 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 12, 2023 10:55 Destroyed
poulch
poulch previously approved these changes Dec 12, 2023
@github-actions github-actions bot temporarily deployed to pr-environment-link December 12, 2023 12:08 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 12, 2023 12:08 Destroyed
import React from "react";
import { FormattedMessage } from "react-intl";

const generateEnvLink = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: can you add two utms to those links?

utm_source=dashboard&utm_content=sidebar_button

@github-actions github-actions bot temporarily deployed to pr-environment-link December 12, 2023 12:29 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 12, 2023 12:29 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 12, 2023 14:14 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 12, 2023 14:14 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 13, 2023 08:30 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 13, 2023 08:30 Destroyed
krzysztofzuraw
krzysztofzuraw previously approved these changes Dec 13, 2023
krzysztofzuraw
krzysztofzuraw previously approved these changes Dec 13, 2023
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 13, 2023 13:01 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 13, 2023 13:01 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 13, 2023 13:02 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 13, 2023 13:02 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 13, 2023 14:11 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 13, 2023 14:12 Destroyed
krzysztofzuraw
krzysztofzuraw previously approved these changes Dec 13, 2023
@github-actions github-actions bot temporarily deployed to pr-environment-link December 14, 2023 12:04 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 14, 2023 12:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 14, 2023 12:08 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 14, 2023 12:08 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-environment-link December 15, 2023 10:14 Destroyed
@github-actions github-actions bot temporarily deployed to pr-environment-link December 15, 2023 10:14 Destroyed
@andrzejewsky andrzejewsky merged commit 3c8f331 into main Dec 18, 2023
16 checks passed
@andrzejewsky andrzejewsky deleted the environment-link branch December 18, 2023 10:17
poulch pushed a commit that referenced this pull request Dec 19, 2023
* Environment link

* Environment link

* Environment link

* Environment link

* Environment link

* Environment link

* Add utm

* Add utm

* Trigger

* Show directly when cloud plugin was used

* Show directly when cloud plugin was used

* Show directly when cloud plugin was used

* Show directly when cloud plugin was used

* Show directly when cloud plugin was used

* Copy

* Messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add link to the related cloud environment
3 participants