Fix showing promotion discount type in order summary (#4689)

* Show promotion discount type * Add changeset
saleor · Feb 26, 2024 · e234ddc · e234ddc
1 parent 232cd2a
commit e234ddc
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 8 deletions.
diff --git a/.changeset/real-brooms-attack.md b/.changeset/real-brooms-attack.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Fix showing promotion discount type in order summary
diff --git a/src/orders/components/OrderSummaryCard/OrderSummaryCard.tsx b/src/orders/components/OrderSummaryCard/OrderSummaryCard.tsx
@@ -2,7 +2,7 @@
 import CardTitle from "@dashboard/components/CardTitle";
 import Link from "@dashboard/components/Link";
 import { giftCardPath } from "@dashboard/giftCards/urls";
-import { OrderDetailsFragment, OrderDiscountType } from "@dashboard/graphql";
+import { OrderDetailsFragment } from "@dashboard/graphql";
 import { Card, CardContent } from "@material-ui/core";
 import { makeStyles } from "@saleor/macaw-ui";
 import React from "react";
@@ -15,6 +15,7 @@ import { SummaryList } from "./SummaryList";
 import {
   extractOrderGiftCardUsedAmount,
   getDeliveryMethodName,
+  getDiscountTypeLabel,
   getTaxTypeText,
 } from "./utils";
 
@@ -71,11 +72,7 @@ const OrderSummaryCard: React.FC<OrderPaymentProps> = ({ order }) => {
             <SummaryLine
               key={discount.id}
               text={<FormattedMessage {...orderSummaryMessages.discount} />}
-              subText={
-                discount.type === OrderDiscountType.MANUAL
-                  ? intl.formatMessage(orderSummaryMessages.staffAdded)
-                  : intl.formatMessage(orderSummaryMessages.voucher)
-              }
+              subText={intl.formatMessage(getDiscountTypeLabel(discount.type))}
               money={discount.amount}
             />
           ))}

diff --git a/src/orders/components/OrderSummaryCard/messages.ts b/src/orders/components/OrderSummaryCard/messages.ts
@@ -70,6 +70,11 @@ export const orderSummaryMessages = defineMessages({
     defaultMessage: "Voucher",
     description: "voucher type order discount",
   },
+  promotion: {
+    id: "TBdxTP",
+    defaultMessage: "Promotion",
+    description: "promotion type order discount",
+  },
   total: {
     id: "zb4eBO",
     defaultMessage: "Total",

diff --git a/src/orders/components/OrderSummaryCard/utils.ts b/src/orders/components/OrderSummaryCard/utils.ts
@@ -1,10 +1,14 @@
 // @ts-strict-ignore
 import { subtractMoney } from "@dashboard/components/Money";
-import { GiftCardEventsEnum, OrderDetailsFragment } from "@dashboard/graphql";
+import {
+  GiftCardEventsEnum,
+  OrderDetailsFragment,
+  OrderDiscountType,
+} from "@dashboard/graphql";
 import { getOrderCharged } from "@dashboard/orders/utils/data";
 import { IMoney } from "@dashboard/utils/intl";
 import compact from "lodash/compact";
-import { IntlShape } from "react-intl";
+import { IntlShape, MessageDescriptor } from "react-intl";
 
 import { orderSummaryMessages } from "./messages";
 
@@ -80,3 +84,17 @@ export const getTaxTypeText = (
   }
   return intl.formatMessage(orderSummaryMessages.vatNotIncluded);
 };
+
+export const getDiscountTypeLabel = (
+  discountType: OrderDiscountType,
+): MessageDescriptor => {
+  switch (discountType) {
+    case OrderDiscountType.MANUAL:
+      return orderSummaryMessages.staffAdded;
+    case OrderDiscountType.PROMOTION:
+    case OrderDiscountType.ORDER_PROMOTION:
+      return orderSummaryMessages.promotion;
+    default:
+      return orderSummaryMessages.voucher;
+  }
+};