Update handle discount rule channel change

saleor · Jan 18, 2025 · d81bc75 · d81bc75
1 parent 0023fb9
commit d81bc75
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/discounts/components/DiscountRules/componenets/RuleForm/RuleForm.tsx b/src/discounts/components/DiscountRules/componenets/RuleForm/RuleForm.tsx
@@ -61,7 +61,14 @@ export const RuleForm = <ErrorCode,>({ errors, openPlayground }: RuleFormProps<E
     }
   }, [currencySymbol]);
 
-  useEffect(() => {
+  const handleChannelChange = (e: ChangeEvent) => {
+    const channelId = e.target.value;
+    const channel = channels.find(channel => channel.id === channelId);
+
+    if (channel) {
+      channelfield.onChange({ value: channel.id, label: channel.name });
+    }
+
     setValue("rewardGifts", []);
 
     // Restart conditions when catalog promotion
@@ -70,15 +77,6 @@ export const RuleForm = <ErrorCode,>({ errors, openPlayground }: RuleFormProps<E
         setValue("conditions", [createEmptyCodition()]);
       }
     }
-  }, [selectedChannel]);
-
-  const handleChannelChange = (e: ChangeEvent) => {
-    const channelId = e.target.value;
-    const channel = channels.find(channel => channel.id === channelId);
-
-    if (channel) {
-      channelfield.onChange({ value: channel.id, label: channel.name });
-    }
   };
 
   return (