Remove brackets next to order status title (#4736)

* Remove brackets * Changeset add
saleor · Mar 19, 2024 · a9745e4 · a9745e4
1 parent 470bc89
commit a9745e4
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 26 deletions.
diff --git a/.changeset/famous-grapes-stare.md b/.changeset/famous-grapes-stare.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": minor
+---
+
+Remove brackets next to each order status title due to cause confusing for the clients
diff --git a/src/orders/components/OrderCardTitle/OrderCardTitle.tsx b/src/orders/components/OrderCardTitle/OrderCardTitle.tsx
@@ -9,7 +9,7 @@ import { FormattedMessage, useIntl } from "react-intl";
 
 import { orderTitleMessages } from "./messages";
 import { useStyles } from "./styles";
-import { getFulfillmentTotalQuantity, getOrderTitleMessage } from "./utils";
+import { getOrderTitleMessage } from "./utils";
 
 export type CardTitleStatus = FulfillmentStatus | "unfulfilled";
 
@@ -19,7 +19,6 @@ export type CardTitleLines = Array<{
 }>;
 
 interface OrderCardTitleProps {
-  lines?: CardTitleLines;
   fulfillmentOrder?: number;
   status: CardTitleStatus;
   toolbar?: React.ReactNode;
@@ -51,7 +50,6 @@ const selectStatus = (status: CardTitleStatus) => {
 };
 
 const OrderCardTitle: React.FC<OrderCardTitleProps> = ({
-  lines = [],
   status,
   warehouseName,
   withStatus = false,
@@ -63,8 +61,6 @@ const OrderCardTitle: React.FC<OrderCardTitleProps> = ({
 
   const messageForStatus = getOrderTitleMessage(status);
 
-  const totalQuantity = getFulfillmentTotalQuantity(lines, status);
-
   return (
     <DefaultCardTitle
       toolbar={toolbar}
@@ -78,7 +74,7 @@ const OrderCardTitle: React.FC<OrderCardTitleProps> = ({
           )}
           <HorizontalSpacer spacing={2} />
           <Typography className={classes.cardHeader}>
-            {intl.formatMessage(messageForStatus)} ({totalQuantity})
+            {intl.formatMessage(messageForStatus)}
           </Typography>
           {!!warehouseName && (
             <Typography className={classes.warehouseName} variant="caption">

diff --git a/src/orders/components/OrderCardTitle/utils.ts b/src/orders/components/OrderCardTitle/utils.ts
@@ -2,22 +2,7 @@
 import camelCase from "lodash/camelCase";
 
 import { orderTitleMessages } from "./messages";
-import { CardTitleLines, CardTitleStatus } from "./OrderCardTitle";
+import { CardTitleStatus } from "./OrderCardTitle";
 
 export const getOrderTitleMessage = (status: CardTitleStatus) =>
   orderTitleMessages[camelCase(status)] || orderTitleMessages.unfulfilled;
-
-export const getFulfillmentTotalQuantity = (
-  lines: CardTitleLines,
-  status: CardTitleStatus,
-) =>
-  status === "unfulfilled"
-    ? lines.reduce(
-        (resultQuantity, line) =>
-          resultQuantity + (line.quantityToFulfill ?? line.quantity),
-        0,
-      )
-    : lines.reduce(
-        (resultQuantity, { quantity }) => resultQuantity + quantity,
-        0,
-      );
diff --git a/src/orders/components/OrderFulfilledProductsCard/OrderFulfilledProductsCard.tsx b/src/orders/components/OrderFulfilledProductsCard/OrderFulfilledProductsCard.tsx
@@ -69,7 +69,6 @@ const OrderFulfilledProductsCard: React.FC<
     <Box data-test-id={dataTestId}>
       <OrderCardTitle
         withStatus
-        lines={fulfillment?.lines}
         fulfillmentOrder={fulfillment?.fulfillmentOrder}
         status={fulfillment?.status}
         warehouseName={fulfillment?.warehouse?.name}

diff --git a/src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx b/src/orders/components/OrderReturnPage/OrderReturnRefundItemsCard/ReturnItemsCard.tsx
@@ -129,7 +129,6 @@ const ItemsCard: React.FC<OrderReturnRefundLinesCardProps> = ({
     <Card>
       <OrderCardTitle
         orderNumber={order?.number}
-        lines={lines}
         fulfillmentOrder={fulfillment?.fulfillmentOrder}
         status={fulfillment?.status}
       />

diff --git a/src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx b/src/orders/components/OrderReturnPage/components/ItemsCard/ItemsCard.tsx
@@ -70,7 +70,6 @@ export const ItemsCard: React.FC<OrderReturnRefundLinesCardProps> = ({
     <Card>
       <OrderCardTitle
         orderNumber={order?.number}
-        lines={lines}
         fulfillmentOrder={fulfillment?.fulfillmentOrder}
         status={fulfillment?.status}
       />

diff --git a/src/orders/components/OrderUnfulfilledProductsCard/OrderUnfulfilledProductsCard.tsx b/src/orders/components/OrderUnfulfilledProductsCard/OrderUnfulfilledProductsCard.tsx
@@ -39,7 +39,6 @@ const OrderUnfulfilledProductsCard: React.FC<
     <>
       <Card>
         <OrderCardTitle
-          lines={lines}
           withStatus
           status="unfulfilled"
           className={classes.cardTitle}