Fix collection product url (#5385)

* Fix collection product url * Fix collection product url * Fix collection product url
saleor · Feb 3, 2025 · a4041bb · a4041bb
1 parent 8b93496
commit a4041bb
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 28 deletions.
diff --git a/.changeset/proud-bulldogs-impress.md b/.changeset/proud-bulldogs-impress.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Now product links on the collection points to the correct url.
diff --git a/src/collections/components/CollectionProducts/ProductTableItem.tsx b/src/collections/components/CollectionProducts/ProductTableItem.tsx
@@ -1,5 +1,6 @@
 import { ChannelsAvailabilityDropdown } from "@dashboard/components/ChannelsAvailabilityDropdown";
 import { GridTable } from "@dashboard/components/GridTable";
+import Link from "@dashboard/components/Link";
 import Drag from "@dashboard/icons/Drag";
 import { productUrl } from "@dashboard/products/urls";
 import { useSortable } from "@dnd-kit/sortable";
@@ -70,38 +71,34 @@ export const ProductTableItem = ({
         </Box>
       </GridTable.Cell>
       <GridTable.Cell __height="inherit" padding={0}>
-        <Box
-          as="a"
-          href={href}
-          padding={2}
-          display="flex"
-          alignItems="center"
-          gap={2}
-          height="100%"
-        >
-          {product?.thumbnail ? (
-            <Box borderColor="default1" borderWidth={1} borderRadius={2} borderStyle="solid">
-              <Box
-                as="img"
-                src={product?.thumbnail?.url}
-                alt={product?.name}
-                __width="31px"
-                __height="31px"
-              />
-            </Box>
-          ) : (
-            <EmptyImage />
-          )}
-          <Text>{product?.name}</Text>
-        </Box>
+        <Link href={href}>
+          <Box padding={2} display="flex" alignItems="center" gap={2} height="100%">
+            {product?.thumbnail ? (
+              <Box borderColor="default1" borderWidth={1} borderRadius={2} borderStyle="solid">
+                <Box
+                  as="img"
+                  src={product?.thumbnail?.url}
+                  alt={product?.name}
+                  __width="31px"
+                  __height="31px"
+                />
+              </Box>
+            ) : (
+              <EmptyImage />
+            )}
+            <Text>{product?.name}</Text>
+          </Box>
+        </Link>
       </GridTable.Cell>
       <GridTable.Cell __height="inherit" padding={0}>
-        <Box as="a" href={href} padding={2} display="flex" alignItems="center" height="100%">
-          <Text>{product?.productType.name || <Skeleton />}</Text>
-        </Box>
+        <Link href={href}>
+          <Box padding={2} display="flex" alignItems="center" height="100%">
+            <Text>{product?.productType.name || <Skeleton />}</Text>
+          </Box>
+        </Link>
       </GridTable.Cell>
       <GridTable.Cell __height="inherit" padding={0}>
-        <Box as="a" display="block" height="100%" padding={2}>
+        <Box display="block" height="100%" padding={2}>
           {product && !product?.channelListings?.length ? (
             "-"
           ) : product?.channelListings !== undefined ? (