Skip to content

Commit

Permalink
removed if statement for electron from nightly workflow (#4438)
Browse files Browse the repository at this point in the history
* removed redundant if statemanet from nightly workflow

* changeset added

* switch if statement to check for electron, changed defauly browser to electron

* testmo if statement fix
  • Loading branch information
wojteknowacki authored Nov 14, 2023
1 parent 678f56f commit 505c916
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/itchy-beds-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

removed redundant if statement in nightly workflow blocking e2e tests
8 changes: 4 additions & 4 deletions .github/workflows/tests-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ jobs:
case 'workflow_dispatch':
return browser
case 'schedule':
return 'chrome'
return 'electron'
default:
return 'chrome'
return 'electron'
}
- name: Cypress install
Expand All @@ -167,7 +167,7 @@ jobs:

- name: Cypress run electron
id: cypress-electron
if: ${{ github.event.inputs.tests != 'Critical' && github.event_name != 'repository_dispatch' && contains(fromJSON('["chrome", "all"]'), steps.get-browsers.outputs.result) && ! cancelled() }}
if: ${{ github.event.inputs.tests != 'Critical' && github.event_name != 'repository_dispatch' && contains(fromJSON('["electron", "all"]'), steps.get-browsers.outputs.result) && ! cancelled() }}
uses: ./.github/actions/e2e
with:
apiUrl: ${{ steps.get-env-uri.outputs.ENV_URI }}graphql/
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:
install: false
browser: firefox
- name: Testmo threads submit
if: ${{ github.event.inputs.tests != 'Critical' && github.event_name != 'repository_dispatch' && contains(fromJSON('["chrome", "all"]'), steps.get-browsers.outputs.result) && ! cancelled() }}
if: ${{ github.event.inputs.tests != 'Critical' && github.event_name != 'repository_dispatch' && contains(fromJSON('["electron", "all"]'), steps.get-browsers.outputs.result) && ! cancelled() }}
uses: ./.github/actions/testmo/testmo-threads-submit
with:
testmoUrl: ${{ secrets.TESTMO_URL }}
Expand Down

0 comments on commit 505c916

Please sign in to comment.