Skip to content

Commit

Permalink
replace @ with # in test tags
Browse files Browse the repository at this point in the history
add changeset
  • Loading branch information
szczecha committed Jan 30, 2025
1 parent 53cb75e commit 3c5c575
Show file tree
Hide file tree
Showing 38 changed files with 168 additions and 241 deletions.
5 changes: 5 additions & 0 deletions .changeset/lucky-windows-sin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Test reports no longer mention users due to test tags matching GitHub usernames.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,8 @@
"qa:move-videos": "find cypress/videos -type f -name \"*.js.mp4\" -exec mv {} cypress/reports/mochareports/videos \\;",
"qa:artifact-move-screenshots": "find cypress/reports/*/mochareports -type d -name \"*.js\" -exec mv {} cypress/reports/mochareports \\;",
"qa:artifact-move-videos": "find cypress/reports/*/mochareports/videos -type f -name \"*.js.mp4\" -exec mv {} cypress/reports/mochareports/videos \\;",
"qa:pw-e2e": "npx playwright test --grep @e2e",
"qa:pw-e2e": "npx playwright test --grep \"#e2e\"",
"qa:pw-ui": "npx playwright test --ui"
},
"description": "![Saleor Dashboard](https://user-images.githubusercontent.com/44495184/185379472-2a204c0b-9b7a-4a3e-93c0-2cb85205ed5e.png)"
}
}
5 changes: 2 additions & 3 deletions playwright/tests/apps.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test.beforeEach(({ page }) => {
});

// Adding temporary skip https://linear.app/saleor/issue/QAG-94/remove-skip-from-app-tests
test.skip("TC: SALEOR_119 User should be able to install and configure app from manifest @e2e", async ({
test.skip("TC: SALEOR_119 User should be able to install and configure app from manifest #e2e", async ({
page,
}) => {
await appsPage.gotoAppsList();
Expand Down Expand Up @@ -49,8 +49,7 @@ test.skip("TC: SALEOR_119 User should be able to install and configure app from
await iframeLocator.getByText("Save").click();
await appsPage.expectSuccessBanner();
});

test("TC: SALEOR_120 User should be able to delete thirdparty app @e2e", async () => {
test("TC: SALEOR_120 User should be able to delete thirdparty app #e2e", async () => {
await appPage.waitForNetworkIdleAfterAction(() =>
appPage.goToExistingAppPage(APPS.appToBeDeleted.id),
);
Expand Down
14 changes: 7 additions & 7 deletions playwright/tests/attributes.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const attributeClasses = ["PRODUCT_TYPE", "PAGE_TYPE"];
for (const attr of attributeClasses) {
for (const type of ATTRIBUTES.attributeTypesWithAbilityToAddValues.names) {
const uniqueSlug = `${attr}-${type}-${SALEOR_124_uuid}`;
test(`TC: SALEOR_124 User should be able to create ${attr} ${type} attribute with ability to add values, required, public @e2e @attributes`, async ({page}) => {
test(`TC: SALEOR_124 User should be able to create ${attr} ${type} attribute with ability to add values, required, public #e2e #attributes`, async ({ page }) => {
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
await configurationPage.goToConfigurationView();
await configurationPage.openAttributes();
Expand Down Expand Up @@ -50,7 +50,7 @@ const SALEOR_125_uuid = faker.datatype.uuid();
for (const attr of attributeClasses) {
for (const type of ATTRIBUTES.attributeTypesWithoutAbilityToAddValues.names) {
const uniqueSlug = `${attr}-${type}-${SALEOR_125_uuid}`;
test(`TC: SALEOR_125 User should be able to create ${attr} ${type} attribute without ability to add values, NOT required, private @e2e @attributes`, async ({page}) => {
test(`TC: SALEOR_125 User should be able to create ${attr} ${type} attribute without ability to add values, NOT required, private #e2e #attributes`, async ({ page }) => {
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
await configurationPage.goToConfigurationView();
await configurationPage.openAttributes();
Expand Down Expand Up @@ -83,7 +83,7 @@ const SALEOR_126_uuid = faker.datatype.uuid();
for (const attr of attributeClasses) {
for (const entity of ATTRIBUTES.attributeReferencesEntities.names) {
const uniqueSlug = `${attr}-${entity}-${SALEOR_126_uuid}`;
test(`TC: SALEOR_126 User should be able to create ${attr} References attribute for ${entity}, NOT required, public @e2e @attributes`, async ({page}) => {
test(`TC: SALEOR_126 User should be able to create ${attr} References attribute for ${entity}, NOT required, public #e2e #attributes`, async ({ page }) => {
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
await configurationPage.goToConfigurationView();
await configurationPage.openAttributes();
Expand Down Expand Up @@ -131,7 +131,7 @@ const attributesWithValuesToBeUpdated = [
contentAttrWithValues,
];
for (const attribute of attributesWithValuesToBeUpdated) {
test(`TC: SALEOR_127 User should be able to update attribute values in existing ${attribute.name} attribute @e2e @attributes`, async () => {
test(`TC: SALEOR_127 User should be able to update attribute values in existing ${attribute.name} attribute #e2e #attributes`, async () => {
await attributesPage.waitForNetworkIdleAfterAction(() =>
attributesPage.gotoExistingAttributePage(attribute.id, attribute.name),
);
Expand Down Expand Up @@ -162,7 +162,7 @@ for (const attribute of attributesWithValuesToBeUpdated) {
}

for (const attr of ATTRIBUTES.attributesToBeUpdated) {
test(`TC: SALEOR_128 User should be able to edit existing ${attr.name} attribute @e2e @attributes`, async () => {
test(`TC: SALEOR_128 User should be able to edit existing ${attr.name} attribute #e2e #attributes`, async () => {
await attributesPage.waitForNetworkIdleAfterAction(() =>
attributesPage.gotoExistingAttributePage(attr.id, attr.name),
);
Expand Down Expand Up @@ -195,7 +195,7 @@ const contentAttribute = {
};
const attributesToBeDeleted = [productAttribute, contentAttribute];
for (const attribute of attributesToBeDeleted) {
test(`TC: SALEOR_129 Delete a single ${attribute.name} @e2e @attributes`, async () => {
test(`TC: SALEOR_129 Delete a single ${attribute.name} #e2e #attributes`, async () => {
await attributesPage.gotoExistingAttributePage(
attribute.id,
attribute.name,
Expand All @@ -213,7 +213,7 @@ for (const attribute of attributesToBeDeleted) {
});
}

test("TC: SALEOR_130 Bulk delete attributes @e2e @attributes", async () => {
test("TC: SALEOR_130 Bulk delete attributes #e2e #attributes", async () => {
await attributesPage.gotoListView();
await attributesPage.searchAndFindRowIndexes("e2e attribute to be bulk deleted");
await attributesPage.clickGridCell(0, 0);
Expand Down
13 changes: 4 additions & 9 deletions playwright/tests/categories.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ let categoriesPage: CategoriesPage;
test.beforeEach(({ page }) => {
categoriesPage = new CategoriesPage(page);
});

test("TC: SALEOR_102 Create basic category @e2e @category", async () => {
test("TC: SALEOR_102 Create basic category #e2e #category", async () => {
await categoriesPage.gotoCategoryListView();
await categoriesPage.waitForDOMToFullyLoad();
await categoriesPage.clickCreateNewCategoryButton();
Expand All @@ -22,11 +21,8 @@ test("TC: SALEOR_102 Create basic category @e2e @category", async () => {
await categoriesPage.clickSaveButton();
await categoriesPage.expectSuccessBanner();
});

test("TC: SALEOR_103 Edit category @e2e @category", async () => {
await categoriesPage.gotoExistingCategoriesPage(
CATEGORIES.categoryToBeUpdated.id,
);
test("TC: SALEOR_103 Edit category #e2e #category", async () => {
await categoriesPage.gotoExistingCategoriesPage(CATEGORIES.categoryToBeUpdated.id);
await categoriesPage.typeCategoryName("Updated category");
await categoriesPage.typeCategoryDescription("Utils description updated");
await categoriesPage.clickProductsTabButton();
Expand All @@ -36,8 +32,7 @@ test("TC: SALEOR_103 Edit category @e2e @category", async () => {
"beer to be updated",
);
});

test("TC: SALEOR_104 Bulk delete categories @e2e @category", async () => {
test("TC: SALEOR_104 Bulk delete categories #e2e #category", async () => {
await categoriesPage.gotoCategoryListView();
await categoriesPage.waitForDOMToFullyLoad();
await categoriesPage.checkListRowsBasedOnContainingText(
Expand Down
10 changes: 4 additions & 6 deletions playwright/tests/channels.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ test.beforeEach(({ page }) => {
configurationPage = new ConfigurationPage(page);
channelPage = new ChannelPage(page);
});

test("TC: SALEOR_97 Create basic channel @e2e @channels", async () => {
test("TC: SALEOR_97 Create basic channel #e2e #channels", async () => {
const slugName = new Date().toISOString();

await configurationPage.goToConfigurationView();
Expand All @@ -28,7 +27,7 @@ test("TC: SALEOR_97 Create basic channel @e2e @channels", async () => {
await channelPage.expectSuccessBanner();
});

test("TC: SALEOR_208 Create channel with all settings @e2e @channels", async () => {
test("TC: SALEOR_208 Create channel with all settings #e2e #channels", async () => {
const slugName = new Date().toISOString();

await configurationPage.goToConfigurationView();
Expand All @@ -55,7 +54,7 @@ test("TC: SALEOR_208 Create channel with all settings @e2e @channels", async ()
await expect(channelPage.allowUnpaidOrdersCheckbox).toBeChecked();
});

test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, prio high stock @e2e @channels", async () => {
test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, prio high stock #e2e #channels", async () => {
await channelPage.gotoChannelDetails(CHANNELS.channelToBeEditedSettings.id);
await channelPage.clickTransactionFlowCheckbox();
await channelPage.clickAllowUnpaidOrdersCheckbox();
Expand All @@ -67,8 +66,7 @@ test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, pr
await channelPage.clickSaveButton();
await channelPage.expectSuccessBanner();
});

test("TC: SALEOR_99 Delete channel @e2e @channels", async () => {
test("TC: SALEOR_99 Delete channel #e2e #channels", async () => {
await channelPage.gotoChannelList();
await channelPage.clickDeleteButtonOnRowContainingChannelName(
CHANNELS.channelToBeDeleted.name,
Expand Down
9 changes: 3 additions & 6 deletions playwright/tests/collections.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ let collectionsPage: CollectionsPage;
test.beforeEach(({ page }) => {
collectionsPage = new CollectionsPage(page);
});

test("TC: SALEOR_112 Create collection @collections @e2e", async () => {
test("TC: SALEOR_112 Create collection #collections #e2e", async () => {
await collectionsPage.gotoCollectionsListView();
await collectionsPage.waitForDOMToFullyLoad();
await collectionsPage.clickCreateCollectionButton();
Expand All @@ -28,8 +27,7 @@ test("TC: SALEOR_112 Create collection @collections @e2e", async () => {
await collectionsPage.clickSaveButton();
await collectionsPage.expectSuccessBanner();
});

test("TC: SALEOR_113 Edit collection: assign product @collections @e2e", async () => {
test("TC: SALEOR_113 Edit collection: assign product #collections #e2e", async () => {
const productToBeAssigned = "Bean Juice";
await collectionsPage.gotoExistingCollectionView(
COLLECTIONS.collectionToBeUpdated.id,
Expand All @@ -48,8 +46,7 @@ test("TC: SALEOR_113 Edit collection: assign product @collections @e2e", async (
`Only 1 category should be visible in table`,
).toEqual(1);
});

test("TC: SALEOR_114 Bulk delete collections @collections @e2e", async () => {
test("TC: SALEOR_114 Bulk delete collections #collections #e2e", async () => {
await collectionsPage.gotoCollectionsListView();
await collectionsPage.waitForDOMToFullyLoad();
await collectionsPage.checkListRowsBasedOnContainingText(
Expand Down
22 changes: 11 additions & 11 deletions playwright/tests/customers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test.beforeEach(({ page }) => {
deleteAddressDialog = new DeleteAddressDialog(page);
});

test("TC: SALEOR_199 Create customer @e2e @customer", async () => {
test("TC: SALEOR_199 Create customer #e2e #customer", async () => {
const firstName = faker.name.firstName();
const lastName = faker.name.lastName();
const note = faker.lorem.sentence();
Expand Down Expand Up @@ -56,7 +56,7 @@ test("TC: SALEOR_199 Create customer @e2e @customer", async () => {
await expect(customersPage.customerEmailInput).toHaveValue(email.toLowerCase());
});

test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email @e2e @customer", async () => {
test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email #e2e #customer", async () => {
const firstName = faker.name.firstName();
const lastName = faker.name.lastName();
const note = faker.lorem.sentence();
Expand All @@ -78,7 +78,7 @@ test("TC: SALEOR_200 As an admin I should not be able to create customer with du
await customersPage.expectErrorBannerMessage("User with this Email already exists.");
});

test("TC: SALEOR_201 Update customer account info @e2e @customer", async () => {
test("TC: SALEOR_201 Update customer account info #e2e #customer", async () => {
const firstName = faker.name.firstName();
const lastName = faker.name.lastName();
const email = faker.internet.email();
Expand All @@ -97,23 +97,23 @@ test("TC: SALEOR_201 Update customer account info @e2e @customer", async () => {
await expect(customersPage.customerEmailInput).toHaveValue(email.toLowerCase());
});

test("TC: SALEOR_202 Deactivate a customer @e2e @customer", async () => {
test("TC: SALEOR_202 Deactivate a customer #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.customerToBeDeactivated.id);
await customersPage.customerActiveCheckbox.click();
await customersPage.saveCustomer();
await customersPage.expectSuccessBanner();
await expect(customersPage.customerActiveCheckbox).not.toBeChecked();
});

test("TC: SALEOR_203 Activate a customer @e2e @customer", async () => {
test("TC: SALEOR_203 Activate a customer #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.customerToBeActivated.id);
await customersPage.customerActiveCheckbox.click();
await customersPage.saveCustomer();
await customersPage.expectSuccessBanner();
await expect(customersPage.customerActiveCheckbox).toBeChecked();
});

test("TC: SALEOR_204 Delete customer from the details page @e2e @customer", async () => {
test("TC: SALEOR_204 Delete customer from the details page #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.deleteCustomer.id);
await customersPage.deleteCustomer();
await customersPage.deleteDialog.clickDeleteButton();
Expand All @@ -123,7 +123,7 @@ test("TC: SALEOR_204 Delete customer from the details page @e2e @customer", asyn
await expect(customersPage.emptyDataGridListView).toBeVisible();
});

test("TC: SALEOR_205 Bulk delete customers @e2e @customer", async () => {
test("TC: SALEOR_205 Bulk delete customers #e2e #customer", async () => {
const customersToBeBulkDeleted = CUSTOMERS.customersToBeBulkDeleted.names;

await customersPage.goToCustomersListView();
Expand All @@ -139,7 +139,7 @@ test("TC: SALEOR_205 Bulk delete customers @e2e @customer", async () => {
await expect(customersPage.emptyDataGridListView).toBeVisible();
});

test("TC: SALEOR_206 As an admin I want to add address to the customer and set it as default shipping @e2e @customer", async () => {
test("TC: SALEOR_206 As an admin I want to add address to the customer and set it as default shipping #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
await addressesListPage.clickManageAddresses();
await addressesListPage.clickAddAddressButton();
Expand Down Expand Up @@ -167,7 +167,7 @@ test("TC: SALEOR_206 As an admin I want to add address to the customer and set i
);
});

test("TC: SALEOR_209 As an admin I want to update customer's address and set it as default billing @e2e @customer", async () => {
test("TC: SALEOR_209 As an admin I want to update customer's address and set it as default billing #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
await addressesListPage.clickManageAddresses();
await addressesListPage.clickShowMoreMenu(CUSTOMERS.editCustomer.initialShippingAddress.lastName);
Expand Down Expand Up @@ -198,7 +198,7 @@ test("TC: SALEOR_209 As an admin I want to update customer's address and set it
);
});

test("TC: SALEOR_210 Delete customer's address @e2e @customer", async () => {
test("TC: SALEOR_210 Delete customer's address #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
await addressesListPage.clickManageAddresses();
await addressesListPage.clickShowMoreMenu(CUSTOMERS.editCustomer.initialBillingAddress.lastName);
Expand All @@ -211,7 +211,7 @@ test("TC: SALEOR_210 Delete customer's address @e2e @customer", async () => {
).not.toBeVisible();
});

test("TC: SALEOR_207 Issue a new gift card for the customer @e2e @customer", async () => {
test("TC: SALEOR_207 Issue a new gift card for the customer #e2e #customer", async () => {
const amount = faker.datatype.number(1000).toPrecision(2).toString();

await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
Expand Down
Loading

0 comments on commit 3c5c575

Please sign in to comment.