forked from IBM-Cloud/terraform-provider-ibm
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 2 #2
Open
albee-jhoney
wants to merge
2,080
commits into
sakshiag:master
Choose a base branch
from
albee-jhoney:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch 2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cloudshell account settings ter (sakshiag#1) Cloud Shell account settings resource and datasource * code review changes (IBM-Cloud#3) * Code review changes (IBM-Cloud#4) * code review changes * fix import doc * Code review changes (IBM-Cloud#5) * code review changes * fix import doc * add staging env var
* first commit for schema registry * fix travis error * address review comments * i.correct client err in config.go ii.correct typo: add ` * address reviews based on documentations
This change fixes the TODO comment and replaces `paultyng/ghaction-import-gpg` with `hashicorp/ghaction-import-gpg`.
* Create IBM Cloudant resource and data source This adds new resource and data source for managing IBM Cloudant instances Co-authored-by: Veronika Mátyus <[email protected]> Co-authored-by: Eigel Ildikó <[email protected]> * Update .secrets.baseline * Arrange attributes in docs in alphabetical order * Include APIKEY authentication in Cloudant client instance * Address comments on website documentation * Update .secrets.baseline Co-authored-by: Veronika Mátyus <[email protected]> Co-authored-by: Eigel Ildikó <[email protected]>
* Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts. * Compliance terraform scripts.
…_json in resource_key resource and datasource
Signed-off-by: Yussuf Shaikh <[email protected]>
Signed-off-by: Yussuf Shaikh <[email protected]>
Signed-off-by: Yussuf Shaikh <[email protected]>
Fixes IBM-Cloud#3386 Signed-off-by: Yussuf Shaikh <[email protected]>
…onsole Language Signed-off-by: Yussuf Shaikh <[email protected]>
Added my review edits in contributing file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.