-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-50820 Assignment / LTI improve archive/merge #13188
Merged
Merged
+888
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csev
changed the title
SAK-50820 Support for LTI Assignment typrs archive/merge
SAK-50820 Assignment / LTI improve archive/merge
Jan 14, 2025
ern
reviewed
Jan 15, 2025
assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
Outdated
Show resolved
Hide resolved
csev
force-pushed
the
SAK-50820
branch
2 times, most recently
from
January 15, 2025 18:58
121f52f
to
8247cba
Compare
ern
reviewed
Jan 17, 2025
assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jan 17, 2025
lti/lti-impl/src/java/org/sakaiproject/lti/impl/BaseLTIService.java
Outdated
Show resolved
Hide resolved
ern
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better thanks Dr Chuck
I approved with some minor suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of several commits