Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

fix: Broken Pipeになる問題と接続維持の修正 #83

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

Daaaai0809
Copy link
Contributor

No description provided.

@Daaaai0809 Daaaai0809 requested a review from sor4chi April 28, 2024 19:11
@Daaaai0809 Daaaai0809 self-assigned this Apr 28, 2024
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

てかそもそもこの機能gorilla/websocketにないの?いちいち各自実装してるようには思えん

@Daaaai0809
Copy link
Contributor Author

@sor4chi
ping/pong frameを実装するためのメソッドとかは用意されてるけど実装は各自

Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2024

Deploying meline with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10f2088
Status: ✅  Deploy successful!
Preview URL: https://0dad842e.meline.pages.dev
Branch Preview URL: https://fix-chat-websocket-broken-pi.meline.pages.dev

View logs

@Daaaai0809 Daaaai0809 requested a review from sor4chi April 30, 2024 10:34
@Daaaai0809 Daaaai0809 force-pushed the fix/chat-websocket-broken-pipe-error branch 2 times, most recently from cc388d4 to e1ef97b Compare April 30, 2024 10:51
@Daaaai0809 Daaaai0809 force-pushed the fix/chat-websocket-broken-pipe-error branch from e1ef97b to 10f2088 Compare April 30, 2024 10:56
@Daaaai0809 Daaaai0809 merged commit b93db09 into main Apr 30, 2024
5 checks passed
@Daaaai0809 Daaaai0809 deleted the fix/chat-websocket-broken-pipe-error branch April 30, 2024 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants