Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

feat: 認証機構 #23

Merged
merged 23 commits into from
Nov 15, 2023
Merged

feat: 認証機構 #23

merged 23 commits into from
Nov 15, 2023

Conversation

Daaaai0809
Copy link
Contributor

No description provided.

@Daaaai0809 Daaaai0809 requested a review from sor4chi November 10, 2023 19:33
@Daaaai0809 Daaaai0809 linked an issue Nov 10, 2023 that may be closed by this pull request
認証機構の作成 #4
Closed
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd34c52
Status: ✅  Deploy successful!
Preview URL: https://5db46444.meline.pages.dev
Branch Preview URL: https://feat--4-add-auth.meline.pages.dev

View logs

sor4chi
sor4chi suggested changes Nov 11, 2023
View reviewed changes
scripts/gen-secret.sh Outdated Show resolved Hide resolved
server/cmd/gen_secret/main.go Outdated Show resolved Hide resolved
server/cmd/server/main.go Outdated Show resolved Hide resolved
server/controller/handler/auth_handler.go Outdated Show resolved Hide resolved
server/controller/gateway/auth_gateway.go Outdated Show resolved Hide resolved
server/utils/gen_state.go Outdated Show resolved Hide resolved
server/usecase/user_interactor.go Outdated Show resolved Hide resolved
server/usecase/user_interactor.go Outdated Show resolved Hide resolved
server/infra/mysql/user_repository.go Outdated Show resolved Hide resolved
server/controller/handler/auth_handler.go Outdated Show resolved Hide resolved
@sor4chi
Copy link
Member

sor4chi commented Nov 11, 2023 •
edited
Loading

DockerComposeのprodが動かない、buildが.になってるっぽい
修正できる？

@Daaaai0809
Copy link
Contributor Author

DockerComposeのprodが動かない、buildが.になってるっぽい 修正できる？

COPY --from=builder /app/sql /app/sqlでnot foundなるけどこれは消していいやつ？？

@Daaaai0809 Daaaai0809 requested a review from sor4chi November 12, 2023 09:29
sor4chi
sor4chi suggested changes Nov 12, 2023
View reviewed changes
server/controller/gateway/auth_gateway.go Outdated Show resolved Hide resolved
server/controller/handler/auth_handler.go Outdated Show resolved Hide resolved
server/usecase/user_interactor.go Outdated Show resolved Hide resolved
server/domain/repository/auth_repository.go Outdated Show resolved Hide resolved
server/models/user.go Show resolved Hide resolved
server/migrations/20231028100209_create_user_table.go Outdated Show resolved Hide resolved
@Daaaai0809 Daaaai0809 requested a review from sor4chi November 15, 2023 06:33
sor4chi
sor4chi suggested changes Nov 15, 2023
View reviewed changes
server/infra/github/auth_repository.go Outdated Show resolved Hide resolved
sor4chi
sor4chi suggested changes Nov 15, 2023
View reviewed changes
server/usecase/github_oauth_interactor.go Outdated
GetGithubOAuthToken(ctx context.Context, code string) (string, error)
GetGithubUser(ctx context.Context, token string) (*entity.OAuthUserResponse, error)
CreateAccessToken(ctx context.Context, user *entity.User) (string, error)
GenerateState(b int) string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b -> length

server/controller/handler/oauth_handler.go Outdated
)

const (
b = 32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATE_LENGTH

sor4chi
sor4chi suggested changes Nov 15, 2023
View reviewed changes
.env.example Outdated
@@ -9,3 +7,7 @@ GITHUB_CLIENT_ID=""
GITHUB_CLIENT_SECRET=""

JWT_SECRET="test-jwt-secret"

ENV="development"
# ENV="prod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prod -> production

.env.example Outdated

ENV="development"
# ENV="prod"
FRONT_CALLBACK_URL="http://localhost/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FRONT_CALLBACK_URL="http://localhost/"

sor4chi
sor4chi approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@sor4chi sor4chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様

@sor4chi sor4chi merged commit 22689bf into main Nov 15, 2023
@sor4chi sor4chi deleted the feat/#4_add_auth branch November 15, 2023 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sor4chi sor4chi sor4chi approved these changes

Assignees

@Daaaai0809 Daaaai0809

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

認証機構の作成
2 participants
@Daaaai0809 @sor4chi