Improve is_empty and is_finite in a few cases #39444
Open
+142
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_empty
for cartesian_product now returns True as long as some factor can be determined to be empty, even if other factors' emptiness is unknown.is_finite
for cartesian_product now correctly return "unknown" in case (unknown empty set × infinite set).is_empty
must be provided for e.g.FiniteWords("ab")
for tests to pass. (Unfortunately Sage has two different functionsis_empty
and__bool__
that does almost the exact same thing, I guess we will have to live with it.)is_empty
for union of two sets now returns False as long as the first set is nonempty, regardless of the second set. (also performance optimization, no need to compute the cardinality.)LazyFamily
now hasis_finite
implemented in more cases.📝 Checklist
⌛ Dependencies