Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump GAP to 4.14.0 #39435

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

bump GAP to 4.14.0 #39435

wants to merge 1 commit into from

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Feb 2, 2025

This is a straightforward update of GAP to 4.14.0.
It will fix #39421 (macOS-specific bug breaking gap_packages in some configurations on arm64)

We also drop an upstreamed patch, and a no longer needed patch.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Feb 2, 2025

Documentation preview for this PR (built with commit 0fc1d1b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@culler culler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I got clean builds of gap and gap_packages in the environment where the old gap_packages failed. The resulting GAP is able to load the crypting package.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
This is a straightforward update of GAP to 4.14.0.
It will fix sagemath#39421 (macOS-specific bug breaking gap_packages in some
configurations on arm64)

We also drop an upstreamed patch, and a no longer needed patch.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#39435
Reported by: Dima Pasechnik
Reviewer(s): Marc Culler
@vbraun
Copy link
Member

vbraun commented Feb 4, 2025

spkg-check fails, it expects a dev/log/testinstall2_* file that probably has been renamed

[gap-4.14.0] [spkg-check] testing: /Users/buildbot-sage/worker/sage_git/build/local/var/tmp/sage/build/g\
[gap-4.14.0] [spkg-check] ap-4.14.0/src/tst/testinstall/zmodnze.tst
[gap-4.14.0] [spkg-check]       52 ms (50 ms GC) and 1.32MB allocated for zmodnze.tst
[gap-4.14.0] [spkg-check] -----------------------------------
[gap-4.14.0] [spkg-check] total     29840 ms (12180 ms GC) and 10.3GB allocated
[gap-4.14.0] [spkg-check]               0 failures in 299 files
[gap-4.14.0] [spkg-check] 
[gap-4.14.0] [spkg-check] #I  No errors detected while testing
[gap-4.14.0] [spkg-check] 
[gap-4.14.0] [spkg-check] ================================================================
[gap-4.14.0] [spkg-check] Test log:
[gap-4.14.0] [spkg-check] cat: dev/log/testinstall2_*: No such file or directory
[gap-4.14.0] [spkg-check] ================================================================
[gap-4.14.0] [spkg-check] grep: dev/log/testinstall2_*: No such file or directory
[gap-4.14.0] Passed the test suite for gap-4.14.0.
[gap-4.14.0] Deleting build directory /Users/buildbot-sage/worker/sage_git/build/local/var/tmp/sage/build/gap-4.14.0
[gap-4.14.0] Finished installing gap-4.14.0
[gap-4.14.0] real 1m55.066s user 1m10.136s sys 0m27.011s
make[3]: Target `all-sage' not remade because of errors.
make[2]: *** [all-build] Error 2
make[2]: Target `build-start' not remade because of errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS-specific bug with building GAP packages - upgrade to GAP 4.14 mandatory now
3 participants