-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump GAP to 4.14.0 #39435
base: develop
Are you sure you want to change the base?
bump GAP to 4.14.0 #39435
Conversation
Documentation preview for this PR (built with commit 0fc1d1b; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I got clean builds of gap and gap_packages in the environment where the old gap_packages failed. The resulting GAP is able to load the crypting package.
This is a straightforward update of GAP to 4.14.0. It will fix sagemath#39421 (macOS-specific bug breaking gap_packages in some configurations on arm64) We also drop an upstreamed patch, and a no longer needed patch. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39435 Reported by: Dima Pasechnik Reviewer(s): Marc Culler
spkg-check fails, it expects a
|
This is a straightforward update of GAP to 4.14.0.
It will fix #39421 (macOS-specific bug breaking gap_packages in some configurations on arm64)
We also drop an upstreamed patch, and a no longer needed patch.
📝 Checklist
⌛ Dependencies