Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare del_edge as cpdef #39429

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Feb 1, 2025

Consistent with its parent class; a build warning gets resolved:

warning: /home/runner/work/sage/sage/src/sage/graphs/base/static_sparse_backend.pyx:677:4: Overriding cdef method with def method.

Consistent with its parent class; a build warning gets resolved:
```
warning: /home/runner/work/sage/sage/src/sage/graphs/base/static_sparse_backend.pyx:677:4: Overriding cdef method with def method.
```
@gmou3 gmou3 force-pushed the declare_del_edge_cpdef branch from 4d6a272 to 5cf5a34 Compare February 1, 2025 18:44
Copy link

github-actions bot commented Feb 1, 2025

Documentation preview for this PR (built with commit 5cf5a34; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
    
Consistent with its parent class; a build warning gets resolved:
```
warning: /home/runner/work/sage/sage/src/sage/graphs/base/static_sparse_
backend.pyx:677:4: Overriding cdef method with def method.
```
    
URL: sagemath#39429
Reported by: gmou3
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
    
Consistent with its parent class; a build warning gets resolved:
```
warning: /home/runner/work/sage/sage/src/sage/graphs/base/static_sparse_
backend.pyx:677:4: Overriding cdef method with def method.
```
    
URL: sagemath#39429
Reported by: gmou3
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants