Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sage-cython script #39427

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

It's deprectaed since v8.7 and is no longer in use in sage, so should be safe to be deleted.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Feb 1, 2025

Documentation preview for this PR (built with commit 20c722f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@orlitzky
Copy link
Contributor

orlitzky commented Feb 2, 2025

I'm stealing this script for another purpose in #39376 (which would be ready for review if I weren't waiting for a new repo under github.com/sagemath).

Basically, you can't compile external cython packages against sage-the-distro because cython will use sys.path from the system python, and thus all of sage is hidden from it. To work around that, I made sage-cython a thin wrapper that runs cython using the venv python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants