Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix one optional internet doctest in oeis.py #39422

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

fchapoton
Copy link
Contributor

currently broken for some reason

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Feb 1, 2025

Documentation preview for this PR (built with commit 91181a2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

sage: ee.programs('pari')[0] # optional -- internet
0: default(realprecision, 50080); x=exp(1); for (n=1, 50000, d=floor(x); x=(x-d)*10; write("b001113.txt", n, " ", d)); \\ _Harry J. Smith_, Apr 15 2009
0: {a(n) = binomial(...)};...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chosen form is a bit misleading as the binomial is divided by a polynomial.
Alternatives like binomial(... or binomial(...) / (....)};... are not very clear either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certes. Le but est de rendre le test très robuste envers les modifications frequentes dans OEIS. Nul n'est besoin de verifier le resultat exact. Si ca ne tenait qu'a moi, je mettrais #random devant tous les tests de ce fichier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En effet, les changements fréquents sont pénibles.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 3, 2025
    
currently broken for some reason

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39422
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 4, 2025
    
currently broken for some reason

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39422
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
currently broken for some reason

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39422
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 9, 2025
    
currently broken for some reason

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#39422
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
@vbraun vbraun merged commit 7a03f30 into sagemath:develop Feb 10, 2025
25 of 26 checks passed
@fchapoton fchapoton deleted the one_fix_in_oeis branch February 11, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants