Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some annotations in polyhedral complex #39375

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fchapoton
Copy link
Contributor

add some typing annotations in one file

also some minor code changes

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 5a17f2c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The one line description of many methods will have to be updated in future PRs.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 26, 2025
    
add some typing annotations in one file

also some minor code changes

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39375
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants