-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify use_sources=True in cython compilation #39275
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 6478f43; changes) is ready! 🎉 |
has this fixed any failing tests? |
for some reason (probably some path coincidence or whatever) it works fine on CI either way. Maybe I should figure out some way to test it on CI. |
Please post an explicit example of what fails for you, and the specifics of your Cython setup. |
Okay here it is: if e.g. https://github.com/sagemath/sage/actions/runs/12913561812/job/36011095007#step:10:14938
Side note, do you think it's desirable to test all combinations (Python 3.11, 12 × editable: true, false) each pull request? Or we could cut down to only test e.g. {Python 3.11 non-editable, Python 3.12 editable} on pull request and test the full matrix in pushes to branch. |
There's a bunch of additional things that fail with Maybe we can just merge the first commit in and enable |
In my testing, this allows cython compilation of code with
from sage.[...] cimport [...]
to work when built with meson. Ability to compile cython code when use legacy build system is unaffected.Actually without this change cython compilation works fine on conda & meson CI anyway (probably because of some coincidence, I didn't inspect)
📝 Checklist
⌛ Dependencies