Implemented methods concerning bricks and braces of a matching covered graph #39065

janmenjayap · 2024-12-01T08:07:13Z

The objective of this issue is to implement the methods pertaining to the bricks and brace of a matching covered graph.

More specifically, this PR aims to implement the following two methods:

is_brace() | Check if the (matching covered) graph is a brace
is_brick() | Check if the (matching covered) graph is a brick.

This PR shall address the methods related to bricks, braces and tight cut decomposition of matching covered graphs.

Fixes #38216.
Note that this issue fixes a small part of the mentioned issue.

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.

⌛ Dependencies

This PR depends on the PR #38742 and #38892.

cc: @dcoudert.

github-actions · 2024-12-01T08:49:02Z

Documentation preview for this PR (built with commit 95cfffc; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

src/sage/graphs/matching_covered_graph.py

dcoudert

Check your code to avoid redundant operations.

src/sage/graphs/matching_covered_graph.py

janmenjayap · 2024-12-01T15:17:53Z

Please note that for the following doctest:

One may set the ``coNP_certificate`` to be ``True``::

            sage: H = graphs.HexahedralGraph()
            sage: G = MatchingCoveredGraph(H)
            sage: G.is_brace(coNP_certificate=True)
            (True, None, None)
            sage: C = graphs.CycleGraph(6)
            sage: D = MatchingCoveredGraph(C)
            sage: D.is_brace(coNP_certificate=True)
            (False, [(0, 5, None), (2, 3, None)], {0, 1, 2})

It is passing in my local for the following two commands:

./sage -t src/sage/graphs/matching_covered_graph.py
./sage -t --long --warn-long 30.0 --random-seed=48323011685507437272567463462221430408 src/sage/graphs/matching_covered_graph.py

However, it is failing in the check for Build & Test / test-new (pull_request).

dcoudert · 2024-12-01T15:30:02Z

is the returned certificate valid ? if so, you must make the method or doctest more robust. This might be a side effect of some data structure (set, graph, etc.) that do not guaranty the order of the items.

janmenjayap · 2024-12-01T15:31:37Z

Yes. Both of the certificates are valid.

…

On Sun, 1 Dec, 2024, 9:00 pm David Coudert, ***@***.***> wrote: is the returned certificate valid ? if so, you must make the method or doctest more robust. This might be a side effect of some data structure (set, graph, etc.) that do not guaranty the order of the items. — Reply to this email directly, view it on GitHub <#39065 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT2NIZGAEE2UHVDNIZYYH632DMTQ7AVCNFSM6AAAAABSZM5QQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZHAYTMOBQGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

src/sage/graphs/matching_covered_graph.py

user202729 · 2024-12-03T13:11:31Z

Please note that for the following doctest:
One may set the ``coNP_certificate`` to be ``True``::

            sage: H = graphs.HexahedralGraph()
            sage: G = MatchingCoveredGraph(H)
            sage: G.is_brace(coNP_certificate=True)
            (True, None, None)
            sage: C = graphs.CycleGraph(6)
            sage: D = MatchingCoveredGraph(C)
            sage: D.is_brace(coNP_certificate=True)
            (False, [(0, 5, None), (2, 3, None)], {0, 1, 2})
It is passing in my local for the following two commands:

./sage -t src/sage/graphs/matching_covered_graph.py

./sage -t --long --warn-long 30.0 --random-seed=48323011685507437272567463462221430408 src/sage/graphs/matching_covered_graph.py

However, it is failing in the check for Build & Test / test-new (pull_request).

I don't think it's a very large issue. We have # random for that.

You can then do e.g. manual checking that the result is in some finite list in a TESTS:: block later.

Co-authored-by: user202729 <[email protected]>

dcoudert · 2024-12-07T12:17:02Z

You may implement a method to check that the returned certificate is valid and use it instead of printing the certificate.

src/sage/graphs/matching_covered_graph.py

dcoudert · 2025-01-12T15:15:11Z

something goes wrong with lint.

into bricks_and_braces

janmenjayap · 2025-01-14T13:11:19Z

Please note that I have added additional information in the output of is_brick() and is_brace() (without any extra calculation/ computation) that will be used in other methods (for instance bricks_and_braces() or tight_cut_decomposition()).

Also, (I just realised through some examples and testings that) the implementation of bricks_and_braces() requires the method merge_vertices() to be overwritten. So, it will be great if we could discuss regarding bricks_and_braces() and tight_cut_decomposition() in a separate PR as suggested earlier.

Please let me know if this PR requires any further modifications.

Thank you.

dcoudert

Although you have already put (too) many tests, some parts of the code are not covered by tests. See codecov reports. Please add the missing tests.

dcoudert

LGTM.
It seems difficult to fully satisfy codecov anyway.

@dcoudert

… a matching covered graph  The objective of this issue is to implement the methods pertaining to the bricks and brace of a matching covered graph.    More specifically, this PR aims to implement the following two methods:  - [x] `is_brace()` | Check if the (matching covered) graph is a brace - [x] `is_brick()` | Check if the (matching covered) graph is a brick.      This PR shall address the methods related to bricks, braces and tight cut decomposition of matching covered graphs.  Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned issue. ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies This PR depends on the PR sagemath#38742 and sagemath#38892.    cc: @dcoudert. URL: sagemath#39065 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda, user202729

@dcoudert

… a matching covered graph  The objective of this issue is to implement the methods pertaining to the bricks and brace of a matching covered graph.    More specifically, this PR aims to implement the following two methods:  - [x] `is_brace()` | Check if the (matching covered) graph is a brace - [x] `is_brick()` | Check if the (matching covered) graph is a brick.      This PR shall address the methods related to bricks, braces and tight cut decomposition of matching covered graphs.  Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned issue. ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies This PR depends on the PR sagemath#38742 and sagemath#38892.    cc: @dcoudert. URL: sagemath#39065 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda, user202729

@dcoudert

… a matching covered graph  The objective of this issue is to implement the methods pertaining to the bricks and brace of a matching covered graph.    More specifically, this PR aims to implement the following two methods:  - [x] `is_brace()` | Check if the (matching covered) graph is a brace - [x] `is_brick()` | Check if the (matching covered) graph is a brick.      This PR shall address the methods related to bricks, braces and tight cut decomposition of matching covered graphs.  Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned issue. ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies This PR depends on the PR sagemath#38742 and sagemath#38892.    cc: @dcoudert. URL: sagemath#39065 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda, user202729

dcoudert · 2025-01-25T11:50:35Z

Set it back to positive review after merge with last beta.

janmenjayap · 2025-01-25T12:32:24Z

Hi @dcoudert,
Let me add the relevant examples for those lines which have not been covered, one by one.

dcoudert · 2025-01-25T12:46:14Z

ok

into bricks_and_braces

janmenjayap added 4 commits December 1, 2024 13:25

added is_brace()

66e9724

updated the to do list

86bd2e9

updated the digraph H

dc47497

updated the doctest

e5d74e2

github-actions bot added the s: needs review label Dec 1, 2024

dcoudert suggested changes Dec 1, 2024

View reviewed changes

janmenjayap and others added 5 commits December 1, 2024 17:08

updated is_matching_covered()

4b43897

updated is_brace()

0eb894d

Merge branch 'develop' into bricks_and_braces

ce1e3aa

removed an unnecessary space

451f164

updated the documentation

74ea027

dcoudert suggested changes Dec 1, 2024

View reviewed changes

src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved

src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved

src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved

updated is_brace()

9c3936b

updated is_brace()

430b837

user202729 reviewed Dec 3, 2024

View reviewed changes

src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved

janmenjayap and others added 2 commits December 5, 2024 22:17

Updated math expression formatting

b1b8b8b

Co-authored-by: user202729 <[email protected]>

Merge branch 'develop' into bricks_and_braces

67f484b

janmenjayap and others added 3 commits December 13, 2024 08:52

Merge branch 'develop' into bricks_and_braces

ac8987e

added is_brick()

d319860

updated is_brace()

564cbbb

dcoudert suggested changes Dec 15, 2024

View reviewed changes

janmenjayap and others added 3 commits December 16, 2024 18:41

Merge branch 'develop' into bricks_and_braces

ad33ccf

updated is_brick()

0f6ca22

updated is_brace()

adb95be

janmenjayap and others added 3 commits January 4, 2025 20:27

added a missing whitespace

f2a5abe

fixed RST215 error

f32ef0f

Merge branch 'develop' into bricks_and_braces

acad2dc

janmenjayap added 4 commits January 13, 2025 17:27

updated is_brick()

fa42cd3

merged branch 'bricks_and_braces' of https://github.com/janmenjayap/sage

da04efc

into bricks_and_braces

updated is_brace()

cdaf8e7

updated is_brick()

2b765b3

dcoudert reviewed Jan 14, 2025

View reviewed changes

updated is_brick()

9a95221

dcoudert approved these changes Jan 17, 2025

View reviewed changes

dcoudert added s: positive review c: graph theory and removed s: needs review labels Jan 17, 2025

Merge branch 'develop' into bricks_and_braces

52dc82f

github-actions bot added s: needs review and removed s: positive review labels Jan 25, 2025

dcoudert added s: positive review and removed s: needs review labels Jan 25, 2025

dcoudert added s: needs review and removed s: positive review labels Jan 25, 2025

janmenjayap added 2 commits January 26, 2025 19:11

added doctests for is_brick()

8395396

merged branch 'bricks_and_braces' of https://github.com/janmenjayap/sage

95cfffc

into bricks_and_braces

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented methods concerning bricks and braces of a matching covered graph #39065

Implemented methods concerning bricks and braces of a matching covered graph #39065

janmenjayap commented Dec 1, 2024 •

edited

Loading

github-actions bot commented Dec 1, 2024 •

edited

Loading

dcoudert left a comment

janmenjayap commented Dec 1, 2024

dcoudert commented Dec 1, 2024

janmenjayap commented Dec 1, 2024 via email

user202729 commented Dec 3, 2024

dcoudert commented Dec 7, 2024

dcoudert commented Jan 12, 2025

janmenjayap commented Jan 14, 2025

dcoudert left a comment

dcoudert left a comment

dcoudert commented Jan 25, 2025

janmenjayap commented Jan 25, 2025 •

edited

Loading

dcoudert commented Jan 25, 2025

Implemented methods concerning bricks and braces of a matching covered graph #39065

Are you sure you want to change the base?

Implemented methods concerning bricks and braces of a matching covered graph #39065

Conversation

janmenjayap commented Dec 1, 2024 • edited Loading

📝 Checklist

⌛ Dependencies

github-actions bot commented Dec 1, 2024 • edited Loading

dcoudert left a comment

Choose a reason for hiding this comment

janmenjayap commented Dec 1, 2024

dcoudert commented Dec 1, 2024

janmenjayap commented Dec 1, 2024 via email

user202729 commented Dec 3, 2024

dcoudert commented Dec 7, 2024

dcoudert commented Jan 12, 2025

janmenjayap commented Jan 14, 2025

dcoudert left a comment

Choose a reason for hiding this comment

dcoudert left a comment

Choose a reason for hiding this comment

dcoudert commented Jan 25, 2025

janmenjayap commented Jan 25, 2025 • edited Loading

dcoudert commented Jan 25, 2025

janmenjayap commented Dec 1, 2024 •

edited

Loading

github-actions bot commented Dec 1, 2024 •

edited

Loading

janmenjayap commented Jan 25, 2025 •

edited

Loading