[Certora Audit] G-03. ERC165Handler.setSupportedInterface(): Logic and storage access optimization
#890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedcu
changed the title
ERC165Handler.setSupportedInterface(): Logic and storage access optimizationERC165Handler.setSupportedInterface(): Logic and storage access optimization
mmv08
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an important update to the
ERC165Handlercontract to improve the handling of interface support and streamline the code. The most significant changes are as follows:The following optimizes the logic and minimizes storage accesses:
contracts/handler/extensible/ERC165Handler.sol: Refactored the logic for checking and updating the support status of interfaces by introducing a localmappingreference. This change simplifies the code and ensures that the interface support status is updated correctly.