Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification migration #2063

Merged
merged 28 commits into from
Dec 5, 2024
Merged

Notification migration #2063

merged 28 commits into from
Dec 5, 2024

Conversation

PooyaRaki
Copy link
Contributor

Summary

Add compatibility between Notification V1 and Notification V2. Integrate Notification V2 methods into Notification V1 to begin populating the database in advance of the data migration, ensuring clients can transition to V2 seamlessly without any changes on their end.

Changes

  • Integrate V2 methods within the V1 controller.
  • Refactor the V2 repository using TypeORM.

@PooyaRaki PooyaRaki force-pushed the notificationMigration branch from cf83376 to f53fa31 Compare October 27, 2024 17:16
@PooyaRaki PooyaRaki mentioned this pull request Oct 28, 2024
Merged
@PooyaRaki PooyaRaki force-pushed the notificationMigration branch 4 times, most recently from 19e7c42 to a28bfab Compare November 4, 2024 12:07
@PooyaRaki PooyaRaki marked this pull request as ready for review November 4, 2024 12:16
@PooyaRaki PooyaRaki requested a review from a team as a code owner November 4, 2024 12:16
iamacook
iamacook reviewed Nov 4, 2024
View reviewed changes
src/datasources/notifications/entities/__tests__/notification-devices.entity.db.builder.ts Show resolved Hide resolved
src/datasources/notifications/entities/__tests__/notification-subscription.entity.db.builder.ts Show resolved Hide resolved
src/datasources/notifications/entities/__tests__/notification-subscription.entity.db.builder.ts Outdated Show resolved Hide resolved
src/datasources/notifications/entities/__tests__/notification-subscription.entity.db.builder.ts Show resolved Hide resolved
src/datasources/notifications/entities/notification-devices.entity.db.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.ts Outdated Show resolved Hide resolved
src/routes/notifications/v2/entities/upsert-subscriptions.dto.entity.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.ts Outdated Show resolved Hide resolved
iamacook
iamacook approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my comments can be tackled in a follow up as they are validation focused. I would suggest we add schema tests for those implemented here as well.

src/datasources/notifications/entities/__tests__/notification-devices.entity.db.builder.ts Show resolved Hide resolved
src/datasources/notifications/entities/__tests__/notification-subscription.entity.db.builder.ts Show resolved Hide resolved
src/datasources/notifications/entities/notification-devices.entity.db.ts Outdated Show resolved Hide resolved
src/datasources/notifications/entities/notification-subscription.entity.db.ts Outdated Show resolved Hide resolved
src/datasources/notifications/entities/notification-devices.entity.db.ts Outdated Show resolved Hide resolved
src/domain/notifications/v2/entities/upsert-subscriptions.dto.entity.ts Show resolved Hide resolved
src/domain/notifications/v2/notifications.repository.integration.spec.ts Show resolved Hide resolved
src/domain/notifications/v2/notifications.repository.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.spec.ts Outdated Show resolved Hide resolved
@PooyaRaki PooyaRaki force-pushed the notificationMigration branch from bb16bc1 to 5fc9e0b Compare November 6, 2024 11:43
hectorgomezv
hectorgomezv reviewed Nov 6, 2024
View reviewed changes
migrations/1726752966034-notification.ts Show resolved Hide resolved
migrations/1726752966034-notification.ts Show resolved Hide resolved
migrations/1726752966034-notification.ts Show resolved Hide resolved
src/domain/notifications/v2/notifications.repository.spec.ts Show resolved Hide resolved
src/domain/notifications/v2/notifications.repository.spec.ts Outdated Show resolved Hide resolved
src/domain/notifications/v2/test.notification.repository.interface.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.ts Outdated Show resolved Hide resolved
src/routes/notifications/v1/notifications.controller.ts Show resolved Hide resolved
src/routes/notifications/v1/entities/__tests__/safe-registration.builder.ts Show resolved Hide resolved
src/routes/notifications/v1/entities/__tests__/register-device.dto.builder.ts Show resolved Hide resolved
@PooyaRaki PooyaRaki force-pushed the notificationMigration branch from 15978c2 to 73984fe Compare November 7, 2024 08:56
@hectorgomezv hectorgomezv self-requested a review November 7, 2024 15:48
@PooyaRaki PooyaRaki force-pushed the notificationMigration branch from 037b635 to e6128ff Compare November 8, 2024 11:12
@PooyaRaki PooyaRaki force-pushed the notificationMigration branch from 855d848 to 156d8e4 Compare November 25, 2024 10:23
@PooyaRaki PooyaRaki requested a review from iamacook November 25, 2024 10:32
@PooyaRaki PooyaRaki self-assigned this Dec 5, 2024
@PooyaRaki
Add integration tests to notification repository
b8a4682
@PooyaRaki
chore: refactor notification tests
b3e77cd
@PooyaRaki
remove custom uuid type
c1cecbe
@PooyaRaki
Improve typing and validation schemas
c008ae5
@PooyaRaki
refactor notification controller tests
efb613c
@PooyaRaki
Call notification v2 from v1 using Promise.all
ec4a650
@PooyaRaki
Add validation to notification controller v1, refactor insertSubscrip…
b05dc89 
…tionNotificationTypes
@PooyaRaki
Add comment to insertSubscriptionNotificationTypes to make it more clear
2facc07
@PooyaRaki
Add mising created_at to NotificationSubscriptionSchema
24b11d6
@PooyaRaki
Adds UUIDSchema to NotificationDeviceSchema
f0a3d3c
@PooyaRaki
Improve notification related types, refactor notification tests
fddcb78
@PooyaRaki
chore: Return device uuid directly from the database transaction handler
927d8c5
@PooyaRaki
Get transactionRunner from the callback instead of the database service
9a0e6c1
@PooyaRaki
fix notification repository unit tests
b65acbd
@PooyaRaki
fix typos, moves notification repository mock to __tests__ folder
a547686
@PooyaRaki
add row schema to notification subscription entity
232e651
@PooyaRaki
Add a new migration to clean up notification tables before creating n…
a80866a 
…ew tables
@PooyaRaki
Check whether the notification feature flag is enabled before calling…
aeddbfe 
… notification v2
@PooyaRaki
refactor typing of notification controller
bdf9a89
@PooyaRaki PooyaRaki force-pushed the notificationMigration branch from 5e5999d to bdf9a89 Compare December 5, 2024 10:38
@PooyaRaki PooyaRaki merged commit e455fba into main Dec 5, 2024
21 checks passed
@PooyaRaki PooyaRaki deleted the notificationMigration branch December 5, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@PooyaRaki PooyaRaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PooyaRaki @iamacook @hectorgomezv