Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMMON: set _is_initialized as true after init() #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zingarelli
Copy link

In Sammon's Mapping, property _is_initialized is not being set to true in the init() method. This property is false by default.

When transform() or generator() methods are called and return this.projection, the get projection() from class DR will check _is_initialized and, as it's false, will call the init() method again, thus replacing the values computed for the projection with the initial values.

Setting _is_initialized as true in the end of the init() method fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant