SAMMON: set _is_initialized as true after init() #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sammon's Mapping, property
_is_initialized
is not being set totrue
in theinit()
method. This property isfalse
by default.When
transform()
orgenerator()
methods are called and returnthis.projection
, theget projection()
from classDR
will check_is_initialized
and, as it'sfalse
, will call theinit()
method again, thus replacing the values computed for the projection with the initial values.Setting
_is_initialized
astrue
in the end of theinit()
method fix this problem.