coupon APIをキャッシュする #204
Merged
coupon APIをキャッシュする #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekki
commented
Oct 25, 2024
| // Billing APIは1日1回 AM4:30 (JST) にデータが更新される。 | ||
| // このため、現在時刻がAM4:30 (JST) よりも早ければ当日のAM4:30 (JST)、 | ||
| // 現在時刻がAM4:30 (JST) よりも遅ければ翌日のAM4:30 (JST) を有効期限として扱う。 | ||
| func (c *couponClient) nextCacheExpiresAt() (time.Time, error) { |
There was a problem hiding this comment.
platform/bill.go とロジックが重複してしまっていますが、キャッシュの有効期限はキャッシュを使う側が決定するほうが自然と考えたので、こちらに実装しています。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景・設計
#202 と同様となります。
動作確認
golangのデバッグモードで動作確認をしました。
1. プロセス起動直後に
/metricsにHTTPアクセス2. 再度
/metricsにHTTPアクセス