-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache and add refresh command #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
@ryanccn Hi, just seeing if this would be possible to be merged in? I've been using it regularly and there haven't been any issues. |
I don't think having a dependency on Git and using it for incremental updates makes sense, since nyoom should ideally be as independent from OS dependencies as possible (which is why the unzip functionality is in Rust!). nyoom's source scheme is modeled after Nix's flake references, and with Nix, flakes from known Git providers such as GitHub are downloaded as archives, since
This is why downloading sources as archives and re-fetching them to update makes more sense IMO. I appreciate the loads of work you've put into this PR; however, I don't think I agree with its premise so I won't be able to merge it at the end of the day. |
This adds a refresh command so that people are able to get new changes from the repository source. I also simplified the zip extractor.