Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache and add refresh command #104

Closed
wants to merge 11 commits into from

Conversation

jacksongoode
Copy link

@jacksongoode jacksongoode commented Jul 29, 2024

This adds a refresh command so that people are able to get new changes from the repository source. I also simplified the zip extractor.

@jacksongoode jacksongoode changed the title Add refresh command Cache and add refresh command Jul 29, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@jacksongoode

This comment was marked as duplicate.

@jacksongoode

This comment was marked as duplicate.

@jacksongoode
Copy link
Author

@ryanccn Hi, just seeing if this would be possible to be merged in? I've been using it regularly and there haven't been any issues.

@ryanccn
Copy link
Owner

ryanccn commented Oct 6, 2024

I don't think having a dependency on Git and using it for incremental updates makes sense, since nyoom should ideally be as independent from OS dependencies as possible (which is why the unzip functionality is in Rust!). nyoom's source scheme is modeled after Nix's flake references, and with Nix, flakes from known Git providers such as GitHub are downloaded as archives, since

These are downloaded as tarball archives, rather than through Git. This is often much faster and uses less disk space since it doesn't require fetching the entire history of the repository. On the other hand, it doesn't allow incremental fetching (but full downloads are often faster than incremental fetches!).

This is why downloading sources as archives and re-fetching them to update makes more sense IMO. I appreciate the loads of work you've put into this PR; however, I don't think I agree with its premise so I won't be able to merge it at the end of the day.

@ryanccn ryanccn closed this Oct 6, 2024
@ryanccn ryanccn added the wontfix This will not be worked on label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants