Prevent grep from matching comment #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lookkernel function searches for the pattern 'initrd' in /etc/lilo.conf to determine if the user has an initrd and if so displays the appropriate message. However, the grep command used in the 'if' statement at line 329 will always succeed even if the user doesn't have an initrd line in a kernel block in /etc/lilo.conf. This is due to grep matching a comment line which contains 'initrd' on line 9 of /etc/lilo.conf.
The new grep pattern will only match lines containing the string 'initrd=' which are preceded by zero or more white space starting from the beginning of the line, which will prevent matching commented lines.