Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FloatMenuMakerMap.AddHumanlikeOrders sync delegates #433

Conversation

SokyranTheDragon
Copy link
Member

Comparing the comment of what the delegate was supposed to do with the actual code:

  • The arrest delegate was pointing at ingest
  • The rescue delegate was pointing at capture prisoner
  • The capture slave delegate was pointing at rescue
  • The capture prisoner delegate was pointing at carry to cryptosleep casket
  • The carry to cryptosleep casket delegate was pointing at (bool) check if the thing is a shuttle and allows for the target to be hauled to it
  • The carry to shuttle delegate was pointing at create confirmation for hacking enemy terminal (the option didn't even work due to the 'carry to cryptosleep casket' delegate breaking it, preventing it from appearing)
  • The other FloatMenuMakerMap delegates were correct

I realized something is wrong while investigating this list by @notfood: #428 (comment)

Comparing the comment of what the delegate was supposed to do with the actual code:
- The arrest delegate was pointing at ingest
- The rescue delegate was pointing at capture prisoner
- The capture slave delegate was pointing at rescue
- The capture prisoner delegate was pointing at carry to cryptosleep casket
- The carry to cryptosleep casket delegate was pointing at (bool) check if the thing is a shuttle and allows for the target to be hauled to it
- The carry to shuttle delegate was pointing at create confirmation for hacking enemy terminal (the option didn't even work due to the 'carry to cryptosleep casket' delegate breaking it, preventing it from appearing)
- The other `FloatMenuMakerMap` delegates were correct
@SokyranTheDragon SokyranTheDragon added fix Fixes for a bug or desync. 1.4 Fixes or bugs relating to 1.4 (Not Biotech). labels Apr 1, 2024
@SokyranTheDragon SokyranTheDragon changed the base branch from master to rw-1.4 April 6, 2024 16:49
@SokyranTheDragon
Copy link
Member Author

I've switched the branch from master to rw-1.4. I'll try to go through 1.5 sync methods and delegates later today and clean them up.

@Zetrith
Copy link
Member

Zetrith commented May 24, 2024

I''ll close it, we don't support 1.4 anymore

@Zetrith Zetrith closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4 Fixes or bugs relating to 1.4 (Not Biotech). fix Fixes for a bug or desync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants