[Ruwork][PHPCS] php_unit_internal_class=true.

ruvents · Jul 13, 2018 · 903578e · 903578e
1 parent dde428a
commit 903578e
Show file tree

Hide file tree

Showing 34 changed files with 101 additions and 0 deletions.
diff --git a/.php_cs.dist b/.php_cs.dist
@@ -18,11 +18,13 @@ return PhpCsFixer\Config::create()
         'no_null_property_initialization' => true,
         'no_php4_constructor' => true,
         'no_superfluous_phpdoc_tags' => true,
+        'no_unreachable_default_argument_value' => true,
         'no_unset_on_property' => true,
         'no_useless_else' => true,
         'no_useless_return' => true,
         'ordered_class_elements' => true,
         'ordered_imports' => true,
+        'php_unit_internal_class' => true,
         'phpdoc_no_empty_return' => false,
         'phpdoc_order' => true,
         'phpdoc_types_order' => true,

diff --git a/tests/BundleTest/AbstractBundleTestCaseTest.php b/tests/BundleTest/AbstractBundleTestCaseTest.php
@@ -11,6 +11,9 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 
+/**
+ * @internal
+ */
 class AbstractBundleTestCaseTest extends AbstractBundleTestCase
 {
     public function testExposeService(): void

diff --git a/tests/Paginator/PaginatorBuilderTest.php b/tests/Paginator/PaginatorBuilderTest.php
@@ -7,6 +7,9 @@
 use PHPUnit\Framework\TestCase;
 use Ruwork\Paginator\Provider\ProviderInterface;
 
+/**
+ * @internal
+ */
 class PaginatorBuilderTest extends TestCase
 {
     public function testNoProvider(): void

diff --git a/tests/Paginator/PaginatorTest.php b/tests/Paginator/PaginatorTest.php
@@ -7,6 +7,9 @@
 use PHPUnit\Framework\TestCase;
 use Ruwork\Paginator\Provider\ProviderInterface;
 
+/**
+ * @internal
+ */
 class PaginatorTest extends TestCase
 {
     /**

diff --git a/tests/Paginator/Provider/IterableProviderTest.php b/tests/Paginator/Provider/IterableProviderTest.php
@@ -6,6 +6,9 @@
 
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @internal
+ */
 class IterableProviderTest extends TestCase
 {
     /**

diff --git a/tests/PaginatorBundle/EventListener/PageOutOfRangeExceptionListenerTest.php b/tests/PaginatorBundle/EventListener/PageOutOfRangeExceptionListenerTest.php
@@ -13,6 +13,9 @@
 use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\HttpKernel\KernelEvents;
 
+/**
+ * @internal
+ */
 class PageOutOfRangeExceptionListenerTest extends TestCase
 {
     /**

diff --git a/tests/PaginatorBundle/RuworkPaginatorBundleTest.php b/tests/PaginatorBundle/RuworkPaginatorBundleTest.php
@@ -10,6 +10,9 @@
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Twig\Loader\FilesystemLoader;
 
+/**
+ * @internal
+ */
 class RuworkPaginatorBundleTest extends AbstractBundleTestCase
 {
     public function testUnobtrusiveCompiler(): void

diff --git a/tests/Reform/Extension/DateTimeTypeDefaultDTIExtensionTest.php b/tests/Reform/Extension/DateTimeTypeDefaultDTIExtensionTest.php
@@ -8,6 +8,9 @@
 use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
 
+/**
+ * @internal
+ */
 class DateTimeTypeDefaultDTIExtensionTest extends FormIntegrationTestCase
 {
     public function testInputOptionDefaultsToDTI()

diff --git a/tests/Reform/Extension/DateTypeDefaultDTIExtensionTest.php b/tests/Reform/Extension/DateTypeDefaultDTIExtensionTest.php
@@ -8,6 +8,9 @@
 use Symfony\Component\Form\Extension\Core\Type\DateType;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
 
+/**
+ * @internal
+ */
 class DateTypeDefaultDTIExtensionTest extends FormIntegrationTestCase
 {
     public function testInputOptionDefaultsToDTI()

diff --git a/tests/Reform/Extension/FormTypeNovalidateExtensionTest.php b/tests/Reform/Extension/FormTypeNovalidateExtensionTest.php
@@ -6,6 +6,9 @@
 
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
 
+/**
+ * @internal
+ */
 class FormTypeNovalidateExtensionTest extends FormIntegrationTestCase
 {
     public function testNovalidateAddedToRootForm()

diff --git a/tests/Reform/Extension/TimeTypeDefaultDTIExtensionTest.php b/tests/Reform/Extension/TimeTypeDefaultDTIExtensionTest.php
@@ -8,6 +8,9 @@
 use Symfony\Component\Form\Extension\Core\Type\TimeType;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
 
+/**
+ * @internal
+ */
 class TimeTypeDefaultDTIExtensionTest extends FormIntegrationTestCase
 {
     public function testInputOptionDefaultsToDTI()

diff --git a/tests/ReformBundle/DependencyInjection/ConfigurationTest.php b/tests/ReformBundle/DependencyInjection/ConfigurationTest.php
@@ -7,6 +7,9 @@
 use Matthias\SymfonyConfigTest\PhpUnit\ConfigurationTestCaseTrait;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @internal
+ */
 class ConfigurationTest extends TestCase
 {
     use ConfigurationTestCaseTrait;

diff --git a/tests/ReformBundle/DependencyInjection/RuworkReformExtensionTest.php b/tests/ReformBundle/DependencyInjection/RuworkReformExtensionTest.php
@@ -10,6 +10,9 @@
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Extension\Core\Type\TimeType;
 
+/**
+ * @internal
+ */
 class RuworkReformExtensionTest extends AbstractExtensionTestCase
 {
     public function testDefault()

diff --git a/tests/ReformBundle/RuworkReformBundleTest.php b/tests/ReformBundle/RuworkReformBundleTest.php
@@ -7,6 +7,9 @@
 use PHPUnit\Framework\TestCase;
 use Ruwork\ReformBundle\DependencyInjection\RuworkReformExtension;
 
+/**
+ * @internal
+ */
 class RuworkReformBundleTest extends TestCase
 {
     public function testExtensionClass()

diff --git a/tests/RouteOptionalPrefix/LoaderDecoratorTest.php b/tests/RouteOptionalPrefix/LoaderDecoratorTest.php
@@ -10,6 +10,9 @@
 use Symfony\Component\Routing\Route;
 use Symfony\Component\Routing\RouteCollection;
 
+/**
+ * @internal
+ */
 class LoaderDecoratorTest extends TestCase
 {
     public function testSupports()

diff --git a/tests/RouteOptionalPrefix/RouterDecoratorTest.php b/tests/RouteOptionalPrefix/RouterDecoratorTest.php
@@ -15,6 +15,9 @@
 use Symfony\Component\Routing\Router;
 use Symfony\Component\Routing\RouterInterface;
 
+/**
+ * @internal
+ */
 class RouterDecoratorTest extends TestCase
 {
     public function testSetContext(): void

diff --git a/tests/RoutingToolsBundle/Controller/RemoveTrailingSlashControllerTest.php b/tests/RoutingToolsBundle/Controller/RemoveTrailingSlashControllerTest.php
@@ -9,6 +9,9 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 
+/**
+ * @internal
+ */
 class RemoveTrailingSlashControllerTest extends TestCase
 {
     public function testInvoke()

diff --git a/tests/RoutingToolsBundle/DependencyInjection/ConfigurationTest.php b/tests/RoutingToolsBundle/DependencyInjection/ConfigurationTest.php
@@ -8,6 +8,9 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
+/**
+ * @internal
+ */
 class ConfigurationTest extends TestCase
 {
     use ConfigurationTestCaseTrait;

diff --git a/tests/RoutingToolsBundle/RedirectFactory/RedirectFactoryTest.php b/tests/RoutingToolsBundle/RedirectFactory/RedirectFactoryTest.php
@@ -9,6 +9,9 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 
+/**
+ * @internal
+ */
 class RedirectFactoryTest extends TestCase
 {
     public function testCreateDefault()

diff --git a/tests/RoutingToolsBundle/RuworkRoutingToolsBundleTest.php b/tests/RoutingToolsBundle/RuworkRoutingToolsBundleTest.php
@@ -19,6 +19,9 @@
 use Symfony\Component\Routing\Loader\PhpFileLoader;
 use Symfony\Component\Routing\Router;
 
+/**
+ * @internal
+ */
 class RuworkRoutingToolsBundleTest extends AbstractBundleTestCase
 {
     public function testUnobtrusiveCompilerPasses(): void

diff --git a/tests/RoutingToolsBundle/Twig/BridgeRoutingExtensionTest.php b/tests/RoutingToolsBundle/Twig/BridgeRoutingExtensionTest.php
@@ -12,6 +12,9 @@
 use Symfony\Component\Routing\RouteCollection;
 use Symfony\Component\Routing\Router;
 
+/**
+ * @internal
+ */
 class BridgeRoutingExtensionTest extends TestCase
 {
     /**

diff --git a/tests/RoutingToolsBundle/Twig/RoutingHelpersExtensionTest.php b/tests/RoutingToolsBundle/Twig/RoutingHelpersExtensionTest.php
@@ -8,6 +8,9 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
 
+/**
+ * @internal
+ */
 class RoutingHelpersExtensionTest extends TestCase
 {
     public function testWithEmptyRequest(): void

diff --git a/tests/RunetIdBundle/DependencyInjection/ConfigurationTest.php b/tests/RunetIdBundle/DependencyInjection/ConfigurationTest.php
@@ -7,6 +7,9 @@
 use Matthias\SymfonyConfigTest\PhpUnit\ConfigurationTestCaseTrait;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @internal
+ */
 class ConfigurationTest extends TestCase
 {
     use ConfigurationTestCaseTrait;

diff --git a/tests/RunetIdBundle/Helper/EventDatesExtractorTest.php b/tests/RunetIdBundle/Helper/EventDatesExtractorTest.php
@@ -7,6 +7,9 @@
 use RunetId\Client\Result\Event\InfoResult;
 use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
 
+/**
+ * @internal
+ */
 class EventDatesExtractorTest extends TestCase
 {
     /**

diff --git a/tests/RunetIdBundle/RunetIdBundleTest.php b/tests/RunetIdBundle/RunetIdBundleTest.php
@@ -9,6 +9,9 @@
 use Ruwork\RunetIdBundle\HWIOAuth\ResourceOwner;
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 
+/**
+ * @internal
+ */
 class RunetIdBundleTest extends AbstractBundleTestCase
 {
     public function testServices(): void

diff --git a/tests/RunetIdBundle/Validator/UniqueEmailValidatorTest.php b/tests/RunetIdBundle/Validator/UniqueEmailValidatorTest.php
@@ -13,6 +13,9 @@
 use Symfony\Component\Validator\Test\ConstraintValidatorTestCase;
 use Webthink\Container\SimpleContainer;
 
+/**
+ * @internal
+ */
 class UniqueEmailValidatorTest extends ConstraintValidatorTestCase
 {
     /**

diff --git a/tests/RuworkBundle/RuworkBundleTest.php b/tests/RuworkBundle/RuworkBundleTest.php
@@ -7,6 +7,9 @@
 use PHPUnit\Framework\TestCase;
 use Ruwork\RuworkBundle\DependencyInjection\RuworkExtension;
 
+/**
+ * @internal
+ */
 class RuworkBundleTest extends TestCase
 {
     public function testExtensionClass()

diff --git a/tests/TemplateI18nBundle/DependencyInjection/ConfigurationTest.php b/tests/TemplateI18nBundle/DependencyInjection/ConfigurationTest.php
@@ -7,6 +7,9 @@
 use Matthias\SymfonyConfigTest\PhpUnit\ConfigurationTestCaseTrait;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @internal
+ */
 class ConfigurationTest extends TestCase
 {
     use ConfigurationTestCaseTrait;

diff --git a/tests/TemplateI18nBundle/DependencyInjection/RuworkTemplateI18nExtensionTest.php b/tests/TemplateI18nBundle/DependencyInjection/RuworkTemplateI18nExtensionTest.php
@@ -11,6 +11,9 @@
 use Ruwork\TemplateI18nBundle\Resolver\LocalizedTemplateResolverInterface;
 use Symfony\Component\DependencyInjection\Reference;
 
+/**
+ * @internal
+ */
 class RuworkTemplateI18nExtensionTest extends AbstractExtensionTestCase
 {
     public function testDefault(): void

diff --git a/tests/TemplateI18nBundle/EventListener/TemplateAnnotationListenerTest.php b/tests/TemplateI18nBundle/EventListener/TemplateAnnotationListenerTest.php
@@ -12,6 +12,9 @@
 use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
 use Symfony\Component\HttpKernel\KernelEvents;
 
+/**
+ * @internal
+ */
 class TemplateAnnotationListenerTest extends TestCase
 {
     public function testEventPriorityHigher(): void

diff --git a/tests/TemplateI18nBundle/NamingStrategy/NamingStrategyTest.php b/tests/TemplateI18nBundle/NamingStrategy/NamingStrategyTest.php
@@ -6,6 +6,9 @@
 
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @internal
+ */
 class NamingStrategyTest extends TestCase
 {
     /**

diff --git a/tests/TemplateI18nBundle/Resolver/LocalizedTemplateResolverTest.php b/tests/TemplateI18nBundle/Resolver/LocalizedTemplateResolverTest.php
@@ -11,6 +11,9 @@
 use Twig\Environment;
 use Twig\Template;
 
+/**
+ * @internal
+ */
 class LocalizedTemplateResolverTest extends TestCase
 {
     public function testResolve(): void

diff --git a/tests/TemplateI18nBundle/RuworkReformBundleTest.php b/tests/TemplateI18nBundle/RuworkReformBundleTest.php
@@ -7,6 +7,9 @@
 use PHPUnit\Framework\TestCase;
 use Ruwork\TemplateI18nBundle\DependencyInjection\RuworkTemplateI18nExtension;
 
+/**
+ * @internal
+ */
 class RuworkReformBundleTest extends TestCase
 {
     public function testExtensionClass(): void

diff --git a/tests/UploadBundle/DependencyInjection/ConfigurationTest.php b/tests/UploadBundle/DependencyInjection/ConfigurationTest.php
@@ -7,6 +7,9 @@
 use Matthias\SymfonyConfigTest\PhpUnit\ConfigurationTestCaseTrait;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @internal
+ */
 class ConfigurationTest extends TestCase
 {
     use ConfigurationTestCaseTrait;
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,9 @@ @@
     use PHPUnit\Framework\TestCase;
+    /**
+     * @internal
+     */
     class IterableProviderTest extends TestCase
     {
         /**
@@ Expand Down @@